Show verified badge in collectible header#1799
Conversation
Add a toolbar principal item to CollectibleScene that displays the collectible title alongside a blue checkmark seal when the collection is verified. Introduce CollectibleViewModel.isVerified computed property (assetData.collection.status == .verified) to drive the UI condition.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a visual indicator for verified NFT collections within the collectible detail view. By adding a prominent verified badge next to the collection title, users can quickly identify legitimate and trusted collections, enhancing the overall user experience and confidence when viewing NFTs. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly implements the display of a verified badge in the collectible header by adding a new isVerified property to the CollectibleViewModel and using it in CollectibleScene to conditionally show a checkmark icon. The implementation is clean. I have one suggestion to improve accessibility for screen reader users.
| HStack(spacing: Spacing.tiny) { | ||
| Text(model.title) | ||
| .font(.headline) | ||
| if model.isVerified { | ||
| Images.System.checkmarkSealFill | ||
| .font(.footnote) | ||
| .foregroundStyle(Colors.blue) | ||
| } | ||
| } |
There was a problem hiding this comment.
For better accessibility, consider combining the title and the verified badge into a single accessibility element. This will provide a more coherent experience for screen reader users by announcing the title and its verified status together. Please ensure the string 'verified' is localized.
HStack(spacing: Spacing.tiny) {
Text(model.title)
.font(.headline)
if model.isVerified {
Images.System.checkmarkSealFill
.font(.footnote)
.foregroundStyle(Colors.blue)
}
}
.accessibilityElement(children: .combine)
.accessibilityLabel(model.isVerified ? "\(model.title), verified" : model.title)
| Text(model.title) | ||
| .font(.headline) | ||
| if model.isVerified { | ||
| Images.System.checkmarkSealFill |
2 participants
Add a toolbar principal item to CollectibleScene that displays the collectible title alongside a blue checkmark seal when the collection is verified. Introduce CollectibleViewModel.isVerified computed property (assetData.collection.status == .verified) to drive the UI condition.