Hide notification permission alert after toggling notifications#138
Merged
Hide notification permission alert after toggling notifications#138
Conversation
Split notificationEnable() into enableNotifications() and disableNotifications(). Both call stopAskNotifications() to prevent the global prompt from flashing, and disableNotifications() ensures the alert does not reappear after the user explicitly opts out. Closes #116
…cations-permissions-alert
On pre-TIRAMISU devices no runtime permission is needed, so PushRequest now calls onNotificationEnable() directly instead of showing a custom AlertDialog.
Replace accompanist permissions flow with the AndroidX ActivityResult API and a runtime check. For pre-TIRAMISU devices or when POST_NOTIFICATIONS is already granted, the onNotificationEnable callback is invoked immediately. Otherwise a RequestPermission launcher is used to request POST_NOTIFICATIONS and invoke onNotificationEnable or onDismiss based on the result. Removed the custom AlertDialog/Accompanist-based permission handling and added ContextCompat/LocalContext checks.
DRadmir
force-pushed
the
116-notifications-permissions-alert
branch
from
160b894 to
a628666
Compare
gemdev111
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split notificationEnable() into enableNotifications() and disableNotifications(). Both call stopAskNotifications() to prevent the global prompt from flashing, and disableNotifications() ensures the alert does not reappear after the user explicitly opts out.
Closes #116