Use Chain for DustThreshold and add UI info#149
Merged
Conversation
Change ConfirmError.DustThreshold to carry a Chain instead of a string title so callers can access chain/asset data. Update ConfirmViewModel to construct DustThreshold with owner.chain. Adapt ConfirmScreen to use a short dust-threshold string resource. Add a DustThresholdInfo InfoSheetEntity (with icon, description and docs link) and map the error to that sheet in ConfirmErrorInfo. Also add tools:replace="android:dataExtractionRules" to the AndroidManifest entry.
gemcoder21
reviewed
Apr 15, 2026
gemcoder21
approved these changes
Apr 15, 2026
Contributor
gemcoder21
left a comment
gemcoder21
left a comment
There was a problem hiding this comment.
Needs handling on iOS too, it was not working in the screenshot
gemdev111
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change ConfirmError.DustThreshold to carry a Chain instead of a string title so callers can access chain/asset data. Update ConfirmViewModel to construct DustThreshold with owner.chain. Adapt ConfirmScreen to use a short dust-threshold string resource. Add a DustThresholdInfo InfoSheetEntity (with icon, description and docs link) and map the error to that sheet in ConfirmErrorInfo. Also add tools:replace="android:dataExtractionRules" to the AndroidManifest entry.
Fix: #146