Android swap details: single-sheet provider picker#172
Closed
jonathanchw wants to merge 2 commits intogemwalletcom:mainfrom
Closed
Conversation
Contributor
Author
|
Provider picker consolidation and confirm screen row grouping are Compose layout/structure changes. No state logic was changed. |
Contributor
|
Closing for now, will make adjustments in separate commit with changes to the swap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap details sheet refactored to a single-sheet provider picker with slide animation and themed header (matches iOS). Confirm screen fixed to correctly group wallet/network/swap rows as one contiguous list.
related #108
video5127607918203504602.mp4