feat(android): add percent shortcuts to swap pay input#174
Closed
jonathanchw wants to merge 2 commits intogemwalletcom:mainfrom
Closed
feat(android): add percent shortcuts to swap pay input#174jonathanchw wants to merge 2 commits intogemwalletcom:mainfrom
jonathanchw wants to merge 2 commits intogemwalletcom:mainfrom
Conversation
Contributor
Author
|
The Android Tests / Unit Tests check failed due to the self-hosted runner losing connection mid-build (not a code issue). Please re-run the job by clicking "Re-run failed jobs" on the checks section. Annotations |
Contributor
|
Closing for now, will make adjustments in separate commit with changes to the swap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 25% / 50% / 100% quick-fill buttons to the swap pay input field.
When the pay amount field is focused, the bottom action bar is replaced by a
PayPercentBarshowing percent options and a "Done" button to dismiss the keyboard.SwapScene— rendersPayPercentBarin place of the swap button when keyboard is open and pay field is editableSwapViewModel—onSelectPayPercent(percent)scales the available balance and sets the pay field valueSwapScreen— wiresonSelectPayPercentto the ViewModelvideo5127607918203504612.mp4