Consolidate Android stake flow with iOS parity#178
Merged
Conversation
Stake scene: - Fix rounded top corners on APR card via dynamic ListPosition in itemsPositioned-based section extractor - Tint APR value green and add info button with StakeAprInfo sheet - Add Delegations section header and nav-bar info button opening chain-specific docs URL via new StakeChain.toGemStakeChain() - Route AwaitingWithdrawal delegation taps straight to Confirm with full balance, matching iOS navigationDestination shortcut Delegation scene: - Move delegation status from inline title badge into colored subtitle, matching iOS DelegationView layout - Make Validator cell tappable when explorer URL resolves, opening it via LocalUriHandler (parity with iOS SafariNavigationLink) - Skip Amount scene on Unstake for chains where canChangeAmountOnUnstake is false, going directly to Confirm
Remove StakeUndelegate and StakeRedelegate from the prefillAmount branch so the Amount scene field stays empty and editable, matching iOS where recipientData().amount is nil for these actions. Max button still fills the full delegation balance. StakeWithdraw is left in the prefill branch defensively; the Withdraw flow bypasses the Amount scene on both platforms today.
gemcoder21
reviewed
Apr 22, 2026
| actions = { | ||
| assetInfo.stakeChain?.let { stakeChain -> | ||
| IconButton(onClick = { | ||
| uriHandler.open(context, AppUrl.docs(DocsUrl.Staking(stakeChain.toGemStakeChain()))) |
gemcoder21
reviewed
Apr 22, 2026
| IconButton(onClick = { | ||
| uriHandler.open(context, AppUrl.docs(DocsUrl.Staking(stakeChain.toGemStakeChain()))) | ||
| }) { | ||
| Icon(imageVector = Icons.Outlined.Info, contentDescription = "stake_info") |
Contributor
There was a problem hiding this comment.
Suggested change
| Icon(imageVector = Icons.Outlined.Info, contentDescription = "stake_info") | |
| Icon(imageVector = Icons.Outlined.Info, contentDescription = null) |
gemcoder21
approved these changes
Apr 22, 2026
Expose stakeInfoUrl as a StateFlow on StakeViewModel, matching the iOS StakeSceneViewModel.stakeInfoUrl computed property. StakeScene now receives the resolved URL and no longer depends on AppUrl, DocsUrl, or StakeChain mapping. Drop the non-localized content description on the nav-bar info icon since IconButton already carries the clickable semantic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stake scene:
Delegation scene:
Close: #93