Skip to content

Show empty state immediately on Android NFT and Activity #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gemcoder21 merged 1 commit into from
Apr 21, 2026
Merged

Show empty state immediately on Android NFT and Activity #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../main/kotlin/com/gemwallet/android/features/activities/presents/list/TransactionsScene.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ internal fun TransactionsScene(
)
}
) {
if (transactions.isEmpty() && !loading) {
if (transactions.isEmpty()) {
val hasFilters = chainsFilter.isNotEmpty() || typeFilter.isNotEmpty()
val type = if (hasFilters) {
EmptyContentType.SearchActivity { onClearChainsFilter(); onClearTypesFilter() }
Expand Down
15 changes: 3 additions & 12 deletions .../nft/presents/src/main/kotlin/com/gemwallet/android/features/nft/presents/NftListScene.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import com.gemwallet.android.cases.nft.NftError
import com.gemwallet.android.ui.R
import com.gemwallet.android.ui.components.empty.EmptyContentType
import com.gemwallet.android.ui.components.empty.EmptyContentView
import com.gemwallet.android.ui.components.progress.CircularProgressIndicator20
import com.gemwallet.android.ui.components.screen.Scene
import com.gemwallet.android.ui.models.actions.CancelAction
import com.gemwallet.android.ui.models.actions.NftAssetIdAction
Expand Down Expand Up @@ -77,16 +76,15 @@ fun NftListScene(
},
onClose = if (cancelAction == null) null else { { cancelAction() } } // TODO: Replace to action in scene
) {
val isRefreshing = isLoading && !items.isEmpty()
PullToRefreshBox(
modifier = Modifier.fillMaxSize(),
isRefreshing = isRefreshing,
isRefreshing = isLoading,
onRefresh = viewModel::refresh,
state = pullToRefreshState,
indicator = {
Indicator( // TODO: Out to view library
modifier = Modifier.align(Alignment.TopCenter),
isRefreshing = isRefreshing,
isRefreshing = isLoading,
state = pullToRefreshState,
containerColor = MaterialTheme.colorScheme.background
)
Expand All @@ -112,14 +110,7 @@ fun NftListScene(
return@PullToRefreshBox
}

if (isLoading && items.isEmpty()) {
Box(modifier = Modifier.fillMaxSize()) {
CircularProgressIndicator20(modifier = Modifier.align(Alignment.Center))
}
return@PullToRefreshBox
}

if (!isLoading && items.isEmpty()) {
if (items.isEmpty()) {
LazyColumn(modifier = Modifier.fillMaxSize()) {
item {
EmptyContentView(
Expand Down
2 changes: 2 additions & 0 deletions android/ui/src/main/kotlin/com/gemwallet/android/ui/components/empty/EmptyStateView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.graphics.painter.Painter
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextAlign
import com.gemwallet.android.ui.theme.largeIconSize
import com.gemwallet.android.ui.theme.listItemIconSize
Expand Down Expand Up @@ -88,6 +89,7 @@ fun EmptyStateView(
} else {
MaterialTheme.typography.bodyMedium
},
fontWeight = FontWeight.Medium,
textAlign = TextAlign.Center,
)

Expand Down