Fix Android Monad stake delegation routing#211
Merged
Conversation
Scope delegation lookup by state so multiple positions on the same validator (Active / Activating / Deactivating / AwaitingWithdrawal) open their own detail screen instead of collapsing to the first match. Also hide the orphaned "Manage" header when the actions list is empty, and keep watch wallets off the Confirm screen when tapping an AwaitingWithdrawal row.
gemcoder21
approved these changes
Apr 23, 2026
|
|
||
| @Serializable | ||
| data class DelegationRoute(val validatorId: String, val delegationId: String) | ||
| data class DelegationRoute(val validatorId: String, val delegationId: String, val state: String) |
Contributor
There was a problem hiding this comment.
why do we need to pass state to the route?
| txType = type, | ||
| validatorId = delegation.value?.validator?.id, | ||
| delegationId = delegation.value?.base?.delegationId!! | ||
| delegationId = delegation.value?.base?.delegationId!!, |
…d-monad-stake-delegation-routing
Make buildStake return nullable and null-guard callers via ?.let { call(it) }
to avoid force-unwrap on delegation / assetInfo state flows.
Remove the DelegationState parameter from delegation-related APIs and data access. Updated StakeDao to stop filtering by state, changed StakeRepository.getDelegation to accept only validatorId and delegationId, and removed DelegationState from routes, view models, screens, amount params, and call sites. Unused imports were cleaned up and tests adjusted to the new getDelegation signature. This simplifies delegation lookups by returning delegations regardless of state.
DRadmir
force-pushed
the
fix/android-monad-stake-delegation-routing
branch
from
8fbad83 to
8d36d9c
Compare
Replace the call to signWithdrawal with signStake and map the resulting signatures to ByteArray. Previously the code wrapped a single toByteArray() in a list; this change returns a list of ByteArray from signStake to match the signer API and support multiple signatures.
…d-monad-stake-delegation-routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope delegation lookup by state so multiple positions on the same validator (Active / Activating / Deactivating / AwaitingWithdrawal) open their own detail screen instead of collapsing to the first match.
Also hide the orphaned "Manage" header when the actions list is empty, and keep watch wallets off the Confirm screen when tapping an AwaitingWithdrawal row.