Consolidate date section formatter across Android lists#300
Merged
Conversation
Extract today/yesterday handling and localized long date formatting into a reusable SectionDateFormatter so it draws on app translations instead of DateUtils system strings. Reuse it in DateGroupedList and RecentsBottomSheet, and cover the date branching with a unit test. Closes #285
gemcoder21
reviewed
May 12, 2026
| } | ||
| val title = SectionDateFormatter.format( | ||
| timestamp = timestamp, | ||
| todayLabel = stringResource(R.string.date_today), |
Contributor
There was a problem hiding this comment.
move today and yesterday to config
gemcoder21
reviewed
May 12, 2026
| today = LocalDate.now(clock), | ||
| ) | ||
|
|
||
| fun format( |
Contributor
There was a problem hiding this comment.
is this one used anywhere?
gemcoder21
reviewed
May 12, 2026
| @@ -157,25 +156,22 @@ private fun buildDateSections( | |||
| if (items.isEmpty()) return emptyList() | |||
…idate-date-section-formatter
Turn SectionDateFormatter into a class that takes today/yesterday labels in the constructor and exposes a single format(LocalDate, Locale) method. Group items by LocalDate directly in dateGroupedList and drop the Calendar/end-of-day workaround. Replace RecentsBottomSheet's custom sections with a direct dateGroupedList call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract today/yesterday handling and localized long date formatting into a reusable SectionDateFormatter so it draws on app translations instead of DateUtils system strings. Reuse it in DateGroupedList and RecentsBottomSheet, and cover the date branching with a unit test.
Closes #285