Add rate to swap detail transaction#352
Merged
Merged
Conversation
Solana NFT support added an `nft` parameter to the TransactionLoadMetadata.solana case, but the SolanaSignerTests call sites were not updated, breaking the SignerTests build. Pass `nft: nil` for the three existing non-NFT transfer cases; the signed transaction output is unchanged.
Compute and display swap rates (forward and reverse) in transaction details. Adds TransactionDetailsValue.Rate and a nullable rate property to the aggregate; TransactionDetailsAggregateImpl now computes the rate from swap metadata using AssetRateFormatter and includes it in the value groups. Android: wire up rate in TransactionDetailsScene and add TransactionRateProperty composable to show/toggle forward/reverse. iOS: add TransactionRateViewModel, update TransactionScene and TransactionSceneViewModel to present and switch rate direction. Includes unit tests for Android and iOS to validate rate formatting and nil handling.
gemdev111
approved these changes
May 20, 2026
…detail-transaction # Conflicts: # android/data/coordinators/src/main/kotlin/com/gemwallet/android/data/coordinators/transaction/GetTransactionDetailsImpl.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #346
Close: #292