Correct seq position#22
Merged
mohammedkhalfan merged 2 commits intogencorefacility:masterfrom Sep 23, 2024
Merged
Conversation
Contributor
YuWei-CH
commented
Aug 18, 2024
- Correct single-line annotation by modify start to start(l[3]) to 1 and end(l[4]) to length of seq.
- Tested, by modifying testcase1 and 7 to have incorrect start and end times you still get correct results.
- Handling of multiple-line annotations by:
- Step1: extract all start and end into corresponding set()
- Step2: Find min start and max end
- Step3: Check sequence length, validness of min_start and max_end
- Step4: Adjust start and end. Offset will be 0 if no adjust need
- Step5: Correct start(l[3]) and end(l[4]) by minus offset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.