Skip to content

Conversation

@bruno-blackbird
Copy link
Contributor

Hello,

I added an option to specify the key to use in the generate command, it is useful to set the same key in multiple environments.

PS: Thank you so much for your great work @convenient !

Copy link
Contributor

@convenient convenient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there

Thanks for the PR. This does bring it more inline with the admin user interface, which lets you supply a specific key.

TBH it's not something i'd ever considered, as I very much rely on keeping different keys on different environments as a point of precaution. But it is good to have feature parity with the core admin controller so thank you very much for this 😄

I've a couple of tiny suggestions if you could review? Thanks

@convenient
Copy link
Contributor

@bruno-blackbird
Copy link
Contributor Author

@convenient Thanks for your feedbacks, I applied all of your suggestions.

@convenient
Copy link
Contributor

@bruno-blackbird That last test run came through like

Generating a new encryption key
A new key will be generated for re-encryption, use "--key" to specify a custom key.
The system currently has 1 keys
Generating a new encryption key using the magento core class
_reEncryptSystemConfigurationValues - start
_reEncryptSystemConfigurationValues - end
_reEncryptCreditCardNumbers - start
_reEncryptCreditCardNumbers - end
Cleaning cache
Done
PASS

Thanks for your contribution 🎉

@convenient convenient merged commit 2174b19 into genecommerce:master Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants