Skip to content

fix(terminal): enable copy shortcuts in all terminal sessions#1077

Merged
arnestrickmann merged 1 commit intogeneralaction:mainfrom
jschwxrz:fix/copy-terminal-content
Feb 24, 2026
Merged

fix(terminal): enable copy shortcuts in all terminal sessions#1077
arnestrickmann merged 1 commit intogeneralaction:mainfrom
jschwxrz:fix/copy-terminal-content

Conversation

@jschwxrz
Copy link
Collaborator

summary:

  • ctrl + shift + c and ctrl + c (with selection) now also work in shell terminals, not just agent sessions
  • previously gated behind isAgentSession

fixes #1075
fixes #914

@vercel
Copy link

vercel bot commented Feb 24, 2026

@jschwxrz is attempting to deploy a commit to the General Action Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link

greptile-apps bot commented Feb 24, 2026

Greptile Summary

Extended copy shortcuts (Ctrl+Shift+C and Ctrl+C with selection) to all terminal sessions, not just agent sessions.

  • Removed the isAgentSession boolean that was derived from options.providerId
  • Eliminated the conditional check that gated copy functionality behind agent sessions
  • Copy and paste shortcuts now work consistently in both shell terminals and agent sessions

The change is minimal, safe, and improves UX consistency across terminal types.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is minimal (removes 3 lines), well-tested by existing unit tests, improves consistency, and has no side effects
  • No files require special attention

Important Files Changed

Filename Overview
src/renderer/terminal/TerminalSessionManager.ts Removed isAgentSession gate to enable copy shortcuts in all terminal sessions

Last reviewed commit: 06afa19

@arnestrickmann
Copy link
Contributor

Sick, thanks!

@arnestrickmann arnestrickmann merged commit 4d83f6d into generalaction:main Feb 24, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: cannot copy from integrated terminal [feat]: allow copy paste from agent cli session

2 participants