Skip to content

fix(ci): fix Linux releaseflow#1088

Merged
arnestrickmann merged 1 commit intomainfrom
emdash/pr-linux-98z
Feb 24, 2026
Merged

fix(ci): fix Linux releaseflow#1088
arnestrickmann merged 1 commit intomainfrom
emdash/pr-linux-98z

Conversation

@arnestrickmann
Copy link
Contributor

@arnestrickmann arnestrickmann commented Feb 24, 2026

Summary

Test plan

  • Trigger a Linux release build and verify electron-rebuild completes

@vercel
Copy link

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Building Building Preview, Comment Feb 24, 2026 10:02pm

Request Review

@arnestrickmann arnestrickmann changed the title feat(ci): add Linux and Windows release jobs, migrate to pnpm fix(ci): fix Linux releaseflow Feb 24, 2026
@greptile-apps
Copy link

greptile-apps bot commented Feb 24, 2026

Greptile Summary

This PR adds pkg-config and libsecret-1-dev to the Linux build dependencies in the release workflow. These packages are required for compiling keytar (v7.9.0), a native Node.js module that provides secure credential storage via the OS keychain, which is used for SSH credential management in the application.

Important Note: The PR description appears to describe a different, much larger set of changes (multi-platform release jobs, pnpm migration, Node.js upgrades, architecture verification, etc.) that are not present in this commit. The actual change is a single-line addition of two package names to the Linux dependency installation step. Either the description is from a different PR, or the changes described have already been merged in previous commits.

Confidence Score: 5/5

  • This PR is safe to merge - it's a necessary dependency addition for Linux builds
  • The change adds required system dependencies (pkg-config and libsecret-1-dev) for the keytar native module on Linux. This is a standard, low-risk dependency addition that fixes potential build failures when compiling keytar. The packages are well-established and necessary for keytar's integration with the Linux keychain (libsecret).
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/release.yml Added pkg-config and libsecret-1-dev dependencies for keytar native module compilation on Linux

Last reviewed commit: 3fb894d

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

run: |
sudo apt-get update
sudo apt-get install -y build-essential
sudo apt-get install -y build-essential pkg-config libsecret-1-dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added libsecret-1-dev for keytar native module compilation (required for SSH credential storage via OS keychain)

@arnestrickmann arnestrickmann merged commit 7095b42 into main Feb 24, 2026
6 of 7 checks passed
@arnestrickmann arnestrickmann deleted the emdash/pr-linux-98z branch February 26, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant