fix: make Promise callback async to fix build error#1160
Merged
arnestrickmann merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
The `resolveIdentityAgent()` call uses `await` inside a non-async Promise callback, causing TS1308. Mark the callback as `async` to fix the build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryFixed TypeScript compilation error TS1308 by adding Changes:
The Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| src/main/ipc/sshIpc.ts | Made Promise callback async to allow await usage inside, fixing TypeScript compilation error TS1308 |
Last reviewed commit: d834270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveIdentityAgent()call insshIpc.tsusesawaitinside a non-async Promise callback, causing TypeScript error TS1308 and breaking the build onmain.asyncto fix the compilation error.Test plan
pnpm run buildpasses successfully🤖 Generated with Claude Code