Skip to content

fix: make Promise callback async to fix build error#1160

Merged
arnestrickmann merged 1 commit intomainfrom
fix/ssh-test-connection-build-error
Feb 27, 2026
Merged

fix: make Promise callback async to fix build error#1160
arnestrickmann merged 1 commit intomainfrom
fix/ssh-test-connection-build-error

Conversation

@arnestrickmann
Copy link
Contributor

Summary

  • The resolveIdentityAgent() call in sshIpc.ts uses await inside a non-async Promise callback, causing TypeScript error TS1308 and breaking the build on main.
  • Marks the Promise callback as async to fix the compilation error.

Test plan

  • pnpm run build passes successfully
  • SSH agent-auth connection test still works as expected

🤖 Generated with Claude Code

The `resolveIdentityAgent()` call uses `await` inside a non-async
Promise callback, causing TS1308. Mark the callback as `async` to
fix the build.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Building Building Preview, Comment Feb 27, 2026 8:22pm

Request Review

@arnestrickmann arnestrickmann merged commit abfaafe into main Feb 27, 2026
5 checks passed
@greptile-apps
Copy link

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Fixed TypeScript compilation error TS1308 by adding async keyword to the Promise callback in the SSH connection test handler. This allows the existing await resolveIdentityAgent(config.host) call to work correctly.

Changes:

  • Made the Promise callback async in TEST_CONNECTION handler to fix build error
  • No functional changes - just corrects the async/await syntax

The resolveIdentityAgent function has internal error handling and returns undefined on errors, so this change is safe and won't introduce unhandled promise rejections.

Confidence Score: 5/5

  • Safe to merge - minimal syntax fix with no functional changes
  • This is a one-line syntax fix that resolves a build-blocking TypeScript error. The change is minimal, correct, and doesn't introduce any new logic or security concerns. The awaited function has proper error handling internally.
  • No files require special attention

Important Files Changed

Filename Overview
src/main/ipc/sshIpc.ts Made Promise callback async to allow await usage inside, fixing TypeScript compilation error TS1308

Last reviewed commit: d834270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant