Skip to content

Adjust z-index values, add top padding to mobile sidebar, and ensure …#1163

Merged
arnestrickmann merged 2 commits intogeneralaction:mainfrom
prath47:fix-1154
Feb 28, 2026
Merged

Adjust z-index values, add top padding to mobile sidebar, and ensure …#1163
arnestrickmann merged 2 commits intogeneralaction:mainfrom
prath47:fix-1154

Conversation

@prath47
Copy link
Contributor

@prath47 prath47 commented Feb 27, 2026

fix: #1154

This PR includes changes as:

  1. fixed the left sidebar overlap issue

…left sidebar text labels are always visible.
@vercel
Copy link

vercel bot commented Feb 27, 2026

@prath47 is attempting to deploy a commit to the General Action Team on Vercel.

A member of the Team first needs to authorize it.

@prath47
Copy link
Contributor Author

prath47 commented Feb 27, 2026

image

@greptile-apps
Copy link

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR fixes left sidebar overlap issues through targeted z-index adjustments and layout improvements:

  • Made "Home" and "Skills" text labels always visible in left sidebar (removed responsive hiding) to ensure consistent layout
  • Added top padding to mobile sidebar to prevent titlebar overlap using pt-[var(--tb)]
  • Reduced settings page z-index from 40 to 10, appropriate for its position in the stacking hierarchy
  • Reduced right sidebar z-index from 45 to 30, aligning it with editor components

The changes are focused and address specific overlap issues. The z-index adjustments create a clearer stacking hierarchy.

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - changes are UI-only and focused on fixing layout issues
  • The changes are straightforward CSS/styling adjustments with no logic changes. Minor concern about right sidebar z-index now matching editor z-index (both at 30), which could affect stacking if both components are visible simultaneously, but this may be intentional for the fix
  • Test the right sidebar visibility when editor mode is active to ensure proper stacking behavior with the new z-30 value

Important Files Changed

Filename Overview
src/renderer/components/LeftSidebar.tsx Removed responsive text hiding - "Home" and "Skills" labels now always visible to prevent overlap issues
src/renderer/components/MainContentArea.tsx Reduced settings page z-index from 40 to 10, appropriate for its layer in the stacking hierarchy
src/renderer/components/RightSidebar.tsx Reduced z-index from 45 to 30, now matches EditorMode/CodeEditor z-index which may affect stacking behavior
src/renderer/components/ui/sidebar.tsx Added top padding on mobile sidebar to account for titlebar height, prevents overlap on mobile devices

Last reviewed commit: b8eea0d

@prath47
Copy link
Contributor Author

prath47 commented Feb 27, 2026

@arnestrickmann dont merge it yet let me go through all the possible scenarios here

@arnestrickmann
Copy link
Contributor

thanks! @prath47,
And gotcha, lmk when ready!

@prath47
Copy link
Contributor Author

prath47 commented Feb 28, 2026

@arnestrickmann you can test and merge it now.

@arnestrickmann
Copy link
Contributor

Thanks sir!

@arnestrickmann arnestrickmann merged commit 7ae6f28 into generalaction:main Feb 28, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: small viewport make left sidebar overlap the Settings window

2 participants