fix(ui): hide Open PRs section while loading instead of showing spinner#1419
Merged
arnestrickmann merged 1 commit intomainfrom Mar 11, 2026
Merged
fix(ui): hide Open PRs section while loading instead of showing spinner#1419arnestrickmann merged 1 commit intomainfrom
arnestrickmann merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR removes the "Open PRs" header + spinner shown during initial PR data loading, replacing it with Key observations:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| src/renderer/components/OpenPrsSection.tsx | Replaces the spinner-with-header loading state with return null when loading && prs.length === 0, and removes the unused Spinner import. Clean, minimal change consistent with the existing error/empty-state pattern. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[OpenPrsSection renders] --> B{loading && prs.length === 0?}
B -- "Yes (before)" --> C["Show spinner header\n(removed by this PR)"]
B -- "Yes (after)" --> D[return null\nhide section entirely]
B -- No --> E{error && prs.length === 0?}
E -- Yes --> F[return null]
E -- No --> G{totalCount === 0 && prs.length === 0?}
G -- Yes --> H[return null]
G -- No --> I[Render PR list]
Last reviewed commit: a7c3640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the loading spinner state from the Open PRs section header, returning
nullinstead so the section is completely hidden until PR data has loaded.Changes
OpenPrsSectionwithreturn nullto match the existing pattern used for error and empty statesSpinnerimportMotivation
The loading spinner in the section header created an ugly flash of UI before PR data was available. Hiding the section entirely until data is ready provides a cleaner experience, consistent with how the error and empty states already behave.