Skip to content

fix(terminal): add padding to expanded terminal modal content#1677

Merged
arnestrickmann merged 1 commit intomainfrom
emdash/feat-padding-expanded-terminal-425
Apr 6, 2026
Merged

fix(terminal): add padding to expanded terminal modal content#1677
arnestrickmann merged 1 commit intomainfrom
emdash/feat-padding-expanded-terminal-425

Conversation

@arnestrickmann
Copy link
Copy Markdown
Contributor

@arnestrickmann arnestrickmann commented Apr 6, 2026

Summary

Adds inner padding to the expanded terminal modal so the terminal content doesn't render flush against the modal edge.

Changes

  • Wrapped the terminal container ref in a padding wrapper with p-2 pt-1 to match the embedded terminal inset
  • Applied theme-aware background color (bg-zinc-900 for dark, bg-background for light) to the padding wrapper
  • Moved the click-to-focus handler to the outer wrapper so clicking the padding area also focuses the terminal

Summary by CodeRabbit

  • Style
    • Updated the expanded terminal modal's visual presentation with improved padding and background styling to ensure better visual consistency and alignment within the modal container.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Error Error Apr 6, 2026 2:45pm

Request Review

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0f97bde4-16d5-4f5c-b6cd-1ca022edafe5

📥 Commits

Reviewing files that changed from the base of the PR and between 0074bec and 3b7c0b0.

📒 Files selected for processing (1)
  • src/renderer/components/ExpandedTerminalModal.tsx

📝 Walkthrough

Walkthrough

The expanded terminal modal component's terminal container was refactored to apply inset padding and conditional background styling. The React ref was relocated from the outer container to an inner wrapper, while the outer container maintains click-to-focus behavior.

Changes

Cohort / File(s) Summary
Terminal Modal Styling
src/renderer/components/ExpandedTerminalModal.tsx
Updated terminal container with p-2 pt-1 padding and conditional background classes (bg-zinc-900 for dark mode, bg-background otherwise). Relocated React ref from outer to inner wrapper (h-full w-full overflow-hidden) while preserving click-to-focus handler on outer container.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hopping through the modal maze,
With padding soft and styled glaze,
Refs now nestle deep inside,
Background colors smooth and wide,
Terminal sits with perfect grace!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch emdash/feat-padding-expanded-terminal-425

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arnestrickmann arnestrickmann merged commit c797ed5 into main Apr 6, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant