Skip to content

fix: rm open in button from task details popover#1972

Merged
jschwxrz merged 1 commit into
mainfrom
jona/eng-1189-open-in-button-looks-wrong-in-task-details
May 11, 2026
Merged

fix: rm open in button from task details popover#1972
jschwxrz merged 1 commit into
mainfrom
jona/eng-1189-open-in-button-looks-wrong-in-task-details

Conversation

@jschwxrz
Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 11, 2026

Greptile Summary

This PR removes the "Open In" button from the task details popover, where it duplicated the same control already present in the titlebar's right slot. The isRemoteProject guard and the OpenInMenu import are untouched because both are still referenced in the right-slot render path.

  • Removes one <OpenInMenu> line from <PopoverContent> in ActiveTaskTitlebar, eliminating duplicate UI.
  • No other logic changes; all existing functionality (titlebar button, git actions, issue selector) is preserved.

Confidence Score: 5/5

Safe to merge — one-line removal of a duplicated UI button with no effect on surrounding logic.

The only change is deleting a single JSX element from a popover. The OpenInMenu control continues to render correctly in the titlebar right slot, and neither the isRemoteProject guard nor the import become orphaned. No state, props, or side effects are touched.

No files require special attention.

Important Files Changed

Filename Overview
src/renderer/features/tasks/task-titlebar.tsx Removes the duplicate OpenInMenu from inside the task details popover; the button still exists in the titlebar's right slot. isRemoteProject and the OpenInMenu import remain in use — no dead code introduced.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ActiveTaskTitlebar] --> B[Titlebar leftSlot]
    A --> C[Titlebar rightSlot]
    B --> D[Popover Trigger]
    D --> E[PopoverContent]
    E --> F[Task name display]
    E --> G[Git branch info + buttons]
    E --> H[IssueSelector]
    C --> I[DevServerPills]
    C --> J[OpenInMenu non-remote only]
    C --> K[Terminal toggle]
    C --> L[Sidebar tab toggles]
Loading

Reviews (1): Last reviewed commit: "fix: rm open in button from task details..." | Re-trigger Greptile

@jschwxrz jschwxrz merged commit 7862f5f into main May 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant