Skip to content

fix(command-palette): show resource monitor in search#2025

Merged
arnestrickmann merged 4 commits into
mainfrom
emdash/resource-monitor-not-visible-evbhc
May 17, 2026
Merged

fix(command-palette): show resource monitor in search#2025
arnestrickmann merged 4 commits into
mainfrom
emdash/resource-monitor-not-visible-evbhc

Conversation

@janburzinski
Copy link
Copy Markdown
Collaborator

seems to have gotten accidentally removed from the cmdk

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 14, 2026

Greptile Summary

This PR restores the Resource Monitor action to the command palette's search view, which was accidentally removed. It also refactors the action into a standalone useMemo so it can be reused for both the empty-state suggested lists and the active-query match path.

  • resourceMonitorAction is now memoized separately and added to all three suggested-action allowlists, letting it participate in the existing 7-item filter/sort/slice pipeline.
  • A new matchedResourceMonitor derived value checks both title and subtitle against debouncedQuery and renders the result above ranked database results when it matches.

Confidence Score: 5/5

Safe to merge — the change is well-scoped, restoring a single action to two independent code paths without touching any shared state or data layer.

The refactor is straightforward: resourceMonitorAction is lifted into its own memo and reused correctly in both the empty-state filter pipeline and the active-query match. Both regressions called out in earlier review threads are addressed. No new correctness issues were found.

No files require special attention.

Important Files Changed

Filename Overview
src/renderer/features/command-palette/command-palette-modal.tsx Restores Resource Monitor to command palette search; refactors action into a shared memo for both empty-state suggested lists and query-match rendering. Both previously flagged issues are addressed correctly.

Reviews (2): Last reviewed commit: "fix(command-palette): suggest resource m..." | Re-trigger Greptile

Comment thread src/renderer/features/command-palette/command-palette-modal.tsx
Comment thread src/renderer/features/command-palette/command-palette-modal.tsx
@janburzinski
Copy link
Copy Markdown
Collaborator Author

@greptileai

@arnestrickmann
Copy link
Copy Markdown
Contributor

could you please resolve the conflicts? @janburzinski

# Conflicts:
#	src/renderer/features/command-palette/command-palette-modal.tsx
@janburzinski
Copy link
Copy Markdown
Collaborator Author

@arnestrickmann done :)

Copy link
Copy Markdown
Contributor

@arnestrickmann arnestrickmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@arnestrickmann arnestrickmann merged commit 0af7086 into main May 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants