Skip to content

fix: grok icon#2120

Merged
arnestrickmann merged 3 commits into
mainfrom
emdash/fix-grok-icon-tvpcz
May 19, 2026
Merged

fix: grok icon#2120
arnestrickmann merged 3 commits into
mainfrom
emdash/fix-grok-icon-tvpcz

Conversation

@janburzinski
Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 19, 2026

Greptile Summary

This PR replaces the xAI logo (xai.svg) with a dedicated Grok brand icon (grok.svg) for the Grok CLI provider. The new SVG asset is added and wired up correctly in both agentConfig.ts and agent-provider-registry.ts.

  • src/assets/images/grok.svg — new Grok brand SVG added; valid and self-contained.
  • src/renderer/utils/agentConfig.ts and src/shared/agent-provider-registry.ts — correctly swap from xai.svg/xaiLogoSvg to grok.svg/grokLogoSvg.
  • src/renderer/lib/providers/meta.ts — adds the new grokIcon import and ICONS entry, but the old xaiIcon import and 'xai.svg' ICONS entry are left behind as dead code.

Confidence Score: 4/5

Safe to merge; the icon swap is complete and correct in all functional paths. The only gap is a leftover import and map entry in meta.ts that carries no runtime risk.

The xai import and ICONS entry in meta.ts were not cleaned up alongside the rest of the change. They don't break anything at runtime — the dead key is simply never matched — but they include an unused asset in the bundle and leave the map inconsistent with the registry.

src/renderer/lib/providers/meta.ts — still imports xai.svg and maps it in ICONS even though no provider references that filename.

Important Files Changed

Filename Overview
src/assets/images/grok.svg New SVG asset for the Grok CLI icon, replacing the former xAI logo; the SVG is valid and self-contained.
src/renderer/utils/agentConfig.ts Swaps the xaiLogoSvg import for grokLogoSvg and updates the grok entry in agentConfig; xai import correctly removed.
src/shared/agent-provider-registry.ts Updates grok provider's icon field from xai.svg to grok.svg; change is consistent with the new asset.
src/renderer/lib/providers/meta.ts Adds grok.svg import and ICONS entry for grok, but retains the now-unused xaiIcon import and 'xai.svg' ICONS map entry.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[agent-provider-registry.ts
grok icon: 'grok.svg'] -->|icon key lookup| B[meta.ts ICONS map]
    B -->|'grok.svg'| C[grok.svg asset
new Grok brand SVG]
    B -->|'xai.svg' dead entry| D[xai.svg asset
no longer referenced by any provider]
    E[agentConfig.ts
grok: grokLogoSvg] -->|direct import| C
Loading

Comments Outside Diff (2)

  1. src/renderer/lib/providers/meta.ts, line 29-30 (link)

    P2 The xaiIcon import and its 'xai.svg' ICONS map entry are now dead code. No provider in agent-provider-registry.ts has icon: 'xai.svg' after this PR, so the entry will never be matched and the imported module is bundled for nothing.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: src/renderer/lib/providers/meta.ts
    Line: 29-30
    
    Comment:
    The `xaiIcon` import and its `'xai.svg'` ICONS map entry are now dead code. No provider in `agent-provider-registry.ts` has `icon: 'xai.svg'` after this PR, so the entry will never be matched and the imported module is bundled for nothing.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
  2. src/renderer/lib/providers/meta.ts, line 62-64 (link)

    P2 The 'xai.svg' entry in the ICONS map should also be removed since no provider references that icon filename anymore.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: src/renderer/lib/providers/meta.ts
    Line: 62-64
    
    Comment:
    The `'xai.svg'` entry in the `ICONS` map should also be removed since no provider references that icon filename anymore.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
src/renderer/lib/providers/meta.ts:29-30
The `xaiIcon` import and its `'xai.svg'` ICONS map entry are now dead code. No provider in `agent-provider-registry.ts` has `icon: 'xai.svg'` after this PR, so the entry will never be matched and the imported module is bundled for nothing.

```suggestion
import { AGENT_PROVIDERS, type AgentProviderId } from '@shared/agent-provider-registry';
```

### Issue 2 of 2
src/renderer/lib/providers/meta.ts:62-64
The `'xai.svg'` entry in the `ICONS` map should also be removed since no provider references that icon filename anymore.

```suggestion
  'autohand.svg': autohandIcon,
};
```

Reviews (1): Last reviewed commit: "Fix Grok icon" | Re-trigger Greptile

@arnestrickmann arnestrickmann merged commit dfd33bd into main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants