Skip to content

fix: settings scrollbar layout#2159

Merged
arnestrickmann merged 4 commits into
mainfrom
settings-fixen-scrollbar-a8iug
May 21, 2026
Merged

fix: settings scrollbar layout#2159
arnestrickmann merged 4 commits into
mainfrom
settings-fixen-scrollbar-a8iug

Conversation

@janburzinski
Copy link
Copy Markdown
Collaborator

reported by @mezotv :D

before:
Screenshot 2026-05-21 at 14 10 23

after:
Screenshot 2026-05-21 at 14 10 29

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 21, 2026

Greptile Summary

This PR fixes a scrollbar layout bug in the Settings page where the scrollbar was overlapping the content area, causing visual clutter reported by a user.

  • Adds [scrollbar-gutter:stable] to the scrollable container so the browser permanently reserves space for the scrollbar, preventing layout shifts when it appears or disappears.
  • Adjusts the inner content div padding from symmetric px-1 to pl-1 pr-4, giving the content breathing room away from the scrollbar gutter.

Confidence Score: 4/5

Safe to merge — a small, targeted layout adjustment with no logic changes.

The fix correctly addresses the scrollbar overlap, but the asymmetric padding (pl-1 vs pr-4) may leave content slightly off-center on macOS where overlay scrollbars mean the gutter reservation never activates. Using scrollbar-gutter:stable both-edges would keep content centered without needing the asymmetric padding.

No files require special attention beyond the minor padding asymmetry noted in SettingsPage.tsx.

Important Files Changed

Filename Overview
src/renderer/features/settings/components/SettingsPage.tsx Adds scrollbar-gutter:stable to the scrollable container and adjusts inner padding from symmetric px-1 to asymmetric pl-1 pr-4 to prevent content from being occluded by the scrollbar.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
src/renderer/features/settings/components/SettingsPage.tsx:187-188
The inner div now uses `pl-1` (4px) and `pr-4` (16px), creating 12 px of asymmetric horizontal padding. On macOS with overlay scrollbars, `scrollbar-gutter:stable` is a no-op (the browser spec only reserves space for classic scrollbars), so the extra right padding will subtly shift the `max-w-4xl` content block to the left without any scrollbar gutter to balance it. A common pattern is to use `scrollbar-gutter:stable both-edges` instead, which mirrors the reserved space on both sides and keeps the content visually centered, making extra asymmetric padding unnecessary.

```suggestion
            <div className="min-h-0 min-w-0 flex-1 justify-center overflow-x-hidden overflow-y-auto [scrollbar-gutter:stable_both-edges]">
              <div className="mx-auto w-full max-w-4xl space-y-8 px-1 py-10">
```

Reviews (1): Last reviewed commit: "Fix settings scrollbar layout" | Re-trigger Greptile

Comment thread src/renderer/features/settings/components/SettingsPage.tsx Outdated
@mezotv
Copy link
Copy Markdown
Contributor

mezotv commented May 21, 2026

Geil

@arnestrickmann arnestrickmann merged commit 8c08a17 into main May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants