fix: settings scrollbar layout#2159
Merged
Merged
Conversation
Contributor
Greptile SummaryThis PR fixes a scrollbar layout bug in the Settings page where the scrollbar was overlapping the content area, causing visual clutter reported by a user.
Confidence Score: 4/5Safe to merge — a small, targeted layout adjustment with no logic changes. The fix correctly addresses the scrollbar overlap, but the asymmetric padding ( No files require special attention beyond the minor padding asymmetry noted in
|
| Filename | Overview |
|---|---|
| src/renderer/features/settings/components/SettingsPage.tsx | Adds scrollbar-gutter:stable to the scrollable container and adjusts inner padding from symmetric px-1 to asymmetric pl-1 pr-4 to prevent content from being occluded by the scrollbar. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
src/renderer/features/settings/components/SettingsPage.tsx:187-188
The inner div now uses `pl-1` (4px) and `pr-4` (16px), creating 12 px of asymmetric horizontal padding. On macOS with overlay scrollbars, `scrollbar-gutter:stable` is a no-op (the browser spec only reserves space for classic scrollbars), so the extra right padding will subtly shift the `max-w-4xl` content block to the left without any scrollbar gutter to balance it. A common pattern is to use `scrollbar-gutter:stable both-edges` instead, which mirrors the reserved space on both sides and keeps the content visually centered, making extra asymmetric padding unnecessary.
```suggestion
<div className="min-h-0 min-w-0 flex-1 justify-center overflow-x-hidden overflow-y-auto [scrollbar-gutter:stable_both-edges]">
<div className="mx-auto w-full max-w-4xl space-y-8 px-1 py-10">
```
Reviews (1): Last reviewed commit: "Fix settings scrollbar layout" | Re-trigger Greptile
This reverts commit 0d8d5fa.
Contributor
|
Geil |
arnestrickmann
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reported by @mezotv :D
before:

after:
