Skip to content

fix: inconsistent padding in form controls#2164

Merged
arnestrickmann merged 3 commits into
mainfrom
jan/eng-1353-inconsistent-padding-in-form-controls
May 21, 2026
Merged

fix: inconsistent padding in form controls#2164
arnestrickmann merged 3 commits into
mainfrom
jan/eng-1353-inconsistent-padding-in-form-controls

Conversation

@janburzinski
Copy link
Copy Markdown
Collaborator

summary

  • consistent padding in selecttrigger
  • removed unnecessary hight constraint on tooltiptrigger
image

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 21, 2026

Greptile Summary

This PR addresses visual inconsistencies in form controls by standardising padding on SelectTrigger, removing an overly-broad h-full height constraint from TooltipTrigger, and bumping the custom-sound Button in NotificationSettingsCard from size="sm" (h-7) to the default size (h-8) so it matches the adjacent SelectTrigger.

  • select.tsx: Padding changed from asymmetric py-2 pr-2 pl-2.5 to symmetric px-2.5 py-1; the existing data-[size=default]:h-8 / data-[size=sm]:h-7 height constraints ensure no layout shift.
  • tooltip.tsx: h-full removed from TooltipTrigger, so the tooltip activation area now matches the wrapped element's natural bounds rather than its entire flex-container column.
  • NotificationSettingsCard.tsx: Button height promoted to h-8 (default) with explicit bg-transparent to override the outline variant's bg-background default.

Confidence Score: 5/5

Small, self-contained styling changes with no logic or data-flow impact; safe to merge.

All three files touch only Tailwind class strings. The fixed-height modifiers on SelectTrigger mean the padding reduction has no visible layout effect. The h-full removal from TooltipTrigger is a global change but reviewed across callers — every usage wraps an element with its own explicit size, so shrinking the hover area to match the element is correct behaviour. The Button size bump in NotificationSettingsCard aligns it with the adjacent SelectTrigger height as intended.

No files require special attention.

Important Files Changed

Filename Overview
src/renderer/lib/ui/select.tsx Padding in SelectTrigger simplified from asymmetric py-2 pr-2 pl-2.5 to symmetric px-2.5 py-1; fixed h-8/h-7 height constraints remain, so the visual height is unchanged.
src/renderer/lib/ui/tooltip.tsx Removed h-full from TooltipTrigger's base class, scoping the hover/trigger area to the wrapped element's natural dimensions across all 40 callers.
src/renderer/features/settings/components/NotificationSettingsCard.tsx Removed size="sm" from the custom-sound Button (now defaults to h-8) and added bg-transparent to override the outline variant's bg-background, aligning it with the SelectTrigger height in the same settings row.

Reviews (1): Last reviewed commit: "fix: consistent padding and alignment in..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@arnestrickmann arnestrickmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir

@arnestrickmann arnestrickmann merged commit a8b9e85 into main May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants