fix(pr): align mark ready button loading state#2292
Merged
arnestrickmann merged 1 commit intoMay 29, 2026
Merged
Conversation
Contributor
Greptile SummaryFixes a visual alignment bug in the "Mark ready" button by replacing the CSS grid-based animated spinner reveal with a straightforward conditional render of the
Confidence Score: 5/5Safe to merge — the change is isolated to a single UI component and removes a small animated wrapper in favour of a direct conditional render. The only thing removed is the CSS grid expand/collapse transition; the spinner itself and all interactive behaviour (disabled state, aria-label, onMarkReady callback) remain intact and correct. No files require special attention.
|
| Filename | Overview |
|---|---|
| src/renderer/features/tasks/diff-view/changes-panel/components/pr-entry/merge-footer.tsx | Replaces animated grid-reveal spinner with a simple conditional render, fixing the button alignment issue caused by the -ml-1 negative margin in the collapsed state. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MergeFooter renders] --> B{isDraft?}
B -- Yes --> C{isMarkingReady?}
B -- No --> D[SplitButton with merge actions]
C -- Yes --> E[Render Loader2 spinner + 'Mark ready']
C -- No --> F[Render 'Mark ready' only]
E --> G[Button disabled]
F --> H[Button enabled, onClick onMarkReady]
Reviews (1): Last reviewed commit: "fix(pr): align mark ready button loading..." | Re-trigger Greptile
arnestrickmann
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
fixed the alignment :D
demo:
https://streamable.com/ra3d32