Skip to content

fix(pr): align mark ready button loading state#2292

Merged
arnestrickmann merged 1 commit into
mainfrom
jan/eng-1462-align-mark-ready-button-in-draft-pull-request-state
May 29, 2026
Merged

fix(pr): align mark ready button loading state#2292
arnestrickmann merged 1 commit into
mainfrom
jan/eng-1462-align-mark-ready-button-in-draft-pull-request-state

Conversation

@janburzinski
Copy link
Copy Markdown
Collaborator

summary

fixed the alignment :D

demo:
https://streamable.com/ra3d32

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Greptile Summary

Fixes a visual alignment bug in the "Mark ready" button by replacing the CSS grid-based animated spinner reveal with a straightforward conditional render of the Loader2 icon.

  • The old approach used a grid-cols-[0fr] / grid-cols-[1fr] animation alongside a -ml-1 negative margin in the collapsed state, which was causing the button content to be misaligned even before the loading state was active.
  • The new approach conditionally mounts the spinner only when isMarkingReady is true, eliminating the layout side-effects at the cost of the expand/collapse transition animation.

Confidence Score: 5/5

Safe to merge — the change is isolated to a single UI component and removes a small animated wrapper in favour of a direct conditional render.

The only thing removed is the CSS grid expand/collapse transition; the spinner itself and all interactive behaviour (disabled state, aria-label, onMarkReady callback) remain intact and correct.

No files require special attention.

Important Files Changed

Filename Overview
src/renderer/features/tasks/diff-view/changes-panel/components/pr-entry/merge-footer.tsx Replaces animated grid-reveal spinner with a simple conditional render, fixing the button alignment issue caused by the -ml-1 negative margin in the collapsed state.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[MergeFooter renders] --> B{isDraft?}
    B -- Yes --> C{isMarkingReady?}
    B -- No --> D[SplitButton with merge actions]
    C -- Yes --> E[Render Loader2 spinner + 'Mark ready']
    C -- No --> F[Render 'Mark ready' only]
    E --> G[Button disabled]
    F --> H[Button enabled, onClick onMarkReady]
Loading

Reviews (1): Last reviewed commit: "fix(pr): align mark ready button loading..." | Re-trigger Greptile

@arnestrickmann arnestrickmann merged commit fcc4239 into main May 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants