Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5dafabd to
52f1476
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
aqeelat
pushed a commit
to aqeelat/emdash
that referenced
this pull request
Feb 12, 2026
* Watch git status updates (generalaction#740) * Fix git status watcher cleanup * Harden git status watcher cleanup * Fallback to polling without git status events * Fix git status hook type errors * Harden git status broadcast * Fix forced git status refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Clean extraction of the git status watcher/caching change from #740. Thanks @cschubiner.
Testing
Note
Medium Risk
Introduces new filesystem watching + broadcast logic and changes how git status is refreshed/cached in the renderer, which could cause missed/extra refreshes or watcher leaks on some platforms.
Overview
Adds a main-process git status watcher (
git:watch-status/git:unwatch-status) that uses recursivefs.watch(macOS/Windows only), debounces events, and broadcastsgit:status-changedto all windows with basic error recovery.Updates the renderer to consume these status-change events in
useFileChangesanduseTaskChanges, forcing refreshes when changes are detected while skipping background refresh when the document is hidden/unfocused. Introduces a 30s renderer-sidegetCachedGitStatuscache with in-flight de-duping to reduce repeatedgit:get-statusIPC calls, and extends preload/global Electron API typings for the new watch/unwatch/event APIs.Written by Cursor Bugbot for commit 67baefe. This will update automatically on new commits. Configure here.