Skip to content

Fix config editor theme alignment and reduce perceived loading#764

Merged
rabanspiegel merged 4 commits intomainfrom
emdash/config-file-color-9b5
Feb 6, 2026
Merged

Fix config editor theme alignment and reduce perceived loading#764
rabanspiegel merged 4 commits intomainfrom
emdash/config-file-color-9b5

Conversation

@rabanspiegel
Copy link
Contributor

@rabanspiegel rabanspiegel commented Feb 5, 2026

Summary

  • fix Monaco theme registration timing so project config editor reliably uses app theme on first paint
  • make Monaco custom theme registration instance-safe across editor mounts
  • align config/data file icon colors with explicit light/dark variants for better contrast
  • add lightweight config preloading on user intent (hover/focus/click of Edit config) while keeping existing loading fallback

Validation

  • npm run format
  • npm run lint (passes with existing repo warnings)
  • npm run type-check

Note

Low Risk
UI/UX-focused changes with small, guarded preload calls and no changes to persistence or auth logic; main risk is minor regressions in config modal loading/theme behavior.

Overview
Improves the Monaco-based project config editor by registering custom themes before editor creation (via beforeMount) so the correct app theme applies on first paint, and by making theme registration idempotent per Monaco instance (using a WeakSet).

Reduces perceived latency when opening the config editor by preloading the project config on user intent (hover/focus/click of Edit config) with a per-project guard and retry-on-failure behavior. Also tweaks File Explorer icon colors (notably .env/JSON/YAML/tooling configs) to use explicit light/dark Tailwind variants for better contrast.

Written by Cursor Bugbot for commit abe3113. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 6, 2026 4:44am

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@rabanspiegel rabanspiegel merged commit 4a25262 into main Feb 6, 2026
4 checks passed
@rabanspiegel rabanspiegel deleted the emdash/config-file-color-9b5 branch February 6, 2026 04:57
aqeelat pushed a commit to aqeelat/emdash that referenced this pull request Feb 12, 2026
…alaction#764)

* Fix config editor theming and add lightweight config preloading

* Reset config preload flag when switching projects

* Prevent stale preload failure from resetting new project guard

* Align .env fallback icon color with theme-aware config colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant