fix(ci): use correct electron-rebuild binary name for pnpm #805
Merged
arnestrickmann merged 2 commits intomainfrom Feb 10, 2026
Merged
fix(ci): use correct electron-rebuild binary name for pnpm #805arnestrickmann merged 2 commits intomainfrom
arnestrickmann merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile OverviewGreptile SummaryThis PR updates the release workflow to call the This aligns the workflow with pnpm’s exec resolution (which expects actual binaries in Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .github/workflows/release.yml | Replaces pnpm exec @electron/rebuild with pnpm exec electron-rebuild in two mac build loops so pnpm resolves the actual binary; no functional issues found. |
Sequence Diagram
sequenceDiagram
participant GHA as GitHub Actions Runner
participant PNPM as pnpm
participant BIN as node_modules/.bin/electron-rebuild
participant ER as @electron/rebuild
GHA->>PNPM: pnpm install --frozen-lockfile
GHA->>PNPM: pnpm exec electron-rebuild -f -a <arch> -v <electronVersion> -w <modules>
PNPM->>BIN: resolve and execute electron-rebuild
BIN->>ER: invoke rebuild logic
ER-->>GHA: Rebuild Complete
GHA->>PNPM: pnpm exec electron-builder ... --config.npmRebuild=false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo migrated from npm to pnpm in #789. pnpm exec can only resolve actual binary
names from node_modules/.bin/, unlike npm exec which can resolve scoped package names.
The @electron/rebuild package registers its binary as electron-rebuild — so pnpm exec
@electron/rebuild fails, but pnpm exec electron-rebuild works.
Verified locally: