Skip to content

fix(ci): use correct electron-rebuild binary name for pnpm #805

Merged
arnestrickmann merged 2 commits intomainfrom
fix-release-flow
Feb 10, 2026
Merged

fix(ci): use correct electron-rebuild binary name for pnpm #805
arnestrickmann merged 2 commits intomainfrom
fix-release-flow

Conversation

@arnestrickmann
Copy link
Contributor

The repo migrated from npm to pnpm in #789. pnpm exec can only resolve actual binary
names from node_modules/.bin/, unlike npm exec which can resolve scoped package names.
The @electron/rebuild package registers its binary as electron-rebuild — so pnpm exec
@electron/rebuild fails, but pnpm exec electron-rebuild works.

Verified locally:

  • pnpm exec @electron/rebuild ... → ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL
  • pnpm exec electron-rebuild ... → ✔ Rebuild Complete

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 10, 2026 5:22am

Request Review

@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR updates the release workflow to call the electron-rebuild binary via pnpm exec electron-rebuild (instead of pnpm exec @electron/rebuild) when rebuilding native modules for macOS x64/arm64 builds.

This aligns the workflow with pnpm’s exec resolution (which expects actual binaries in node_modules/.bin) and matches the repo’s existing usage of electron-rebuild in package.json scripts.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change is a targeted workflow command substitution that matches pnpm’s exec semantics and the project’s existing use of electron-rebuild; no additional behavior changes were introduced.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/release.yml Replaces pnpm exec @electron/rebuild with pnpm exec electron-rebuild in two mac build loops so pnpm resolves the actual binary; no functional issues found.

Sequence Diagram

sequenceDiagram
  participant GHA as GitHub Actions Runner
  participant PNPM as pnpm
  participant BIN as node_modules/.bin/electron-rebuild
  participant ER as @electron/rebuild

  GHA->>PNPM: pnpm install --frozen-lockfile
  GHA->>PNPM: pnpm exec electron-rebuild -f -a <arch> -v <electronVersion> -w <modules>
  PNPM->>BIN: resolve and execute electron-rebuild
  BIN->>ER: invoke rebuild logic
  ER-->>GHA: Rebuild Complete
  GHA->>PNPM: pnpm exec electron-builder ... --config.npmRebuild=false
Loading

@arnestrickmann arnestrickmann merged commit bfd7886 into main Feb 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant