Skip to content

fix: don't render files that are to large and suggest to open the file individually#876

Merged
arnestrickmann merged 1 commit intogeneralaction:mainfrom
Laurin-Notemann:fix/all-changes-modal
Feb 15, 2026
Merged

fix: don't render files that are to large and suggest to open the file individually#876
arnestrickmann merged 1 commit intogeneralaction:mainfrom
Laurin-Notemann:fix/all-changes-modal

Conversation

@Laurin-Notemann
Copy link
Contributor

The All changes modal crashed when trying to open a massive pnpm lock file.

this now collapses this file and suggest to open it individually.

@vercel
Copy link

vercel bot commented Feb 15, 2026

@Laurin-Notemann is attempting to deploy a commit to the General Action Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link

greptile-apps bot commented Feb 15, 2026

Greptile Summary

Prevents crashes when viewing massive files (like pnpm lock files) in the All Changes modal by detecting large files through three criteria: line count >2500, content size >300KB, or truncated reads. Large files are collapsed by default and display a user-friendly message with a button to open them individually in the single-file diff viewer instead. Also includes a minor cleanup in AddRemoteProjectModal.tsx where an unused variable assignment was removed.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Clean defensive fix with proper thresholds, clear user feedback, and graceful degradation. The implementation correctly handles edge cases and provides an alternative workflow for large files.
  • No files require special attention

Important Files Changed

Filename Overview
src/renderer/components/AllChangesDiffModal.tsx Added large file detection with three thresholds (line count, content size, truncated read) to prevent crashes when rendering massive files in the all-changes modal
src/renderer/components/FileChangesPanel.tsx Wired up onOpenFile callback to allow users to open large files individually from the all-changes modal

Last reviewed commit: 843f236

@arnestrickmann arnestrickmann merged commit 97aae48 into generalaction:main Feb 15, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants