Refine settings layout and toggle behavior#964
Merged
arnestrickmann merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryRefined settings UI responsiveness and interaction behavior. The changes improve viewport adaptability at higher zoom levels, establish consistent toggle behavior for opening/closing settings, and fix sidebar state persistence across mobile/desktop breakpoints. Major Changes:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| src/renderer/App.tsx | Added handleToggleSettingsPage callback to toggle settings instead of only opening them, improving consistency |
| src/renderer/components/SettingsModal.tsx | Updated modal sizing to be more viewport-aware with responsive width and height constraints |
| src/renderer/components/SettingsPage.tsx | Refactored layout to use centered content rail with max-width containers and grid-based layout |
| src/renderer/components/ThemeCard.tsx | Improved theme option cards to use responsive grid with auto-fit layout and better wrapping under zoom |
| src/renderer/components/ui/sidebar.tsx | Separated desktop and mobile sidebar state to fix persistence issues across breakpoint transitions |
| src/renderer/hooks/useKeyboardShortcuts.ts | Distinguished command palette from settings overlay to keep settings open during global shortcuts |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User Action] --> B{Action Type?}
B -->|Cmd+,| C[handleToggleSettingsPage]
B -->|Settings Button| C
B -->|Global Shortcuts| D[useKeyboardShortcuts]
B -->|Sidebar Toggle| E[SidebarProvider]
C --> F{Settings Open?}
F -->|Yes| G[handleCloseSettingsPage]
F -->|No| H[openSettingsPage]
D --> I{Check Overlay State}
I -->|Command Palette Open| J[Close modal before action]
I -->|Settings Open| K[Allow global shortcuts]
I -->|No Overlay| K
E --> L{Device Type?}
L -->|Mobile| M[Update mobileOpen state]
L -->|Desktop| N[Update desktopOpen state]
N --> O[Persist to localStorage]
H --> P[SettingsPage]
P --> Q[Responsive Layout Grid]
Q --> R[Navigation Sidebar]
Q --> S[Content Rail]
S --> T[ThemeCard with Auto-fit Grid]
Last reviewed commit: 125c1be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Notes
Note
Medium Risk
Mostly UI/layout and shortcut-state changes, but it modifies global keyboard shortcut gating and sidebar open-state persistence, which can cause regressions in navigation/toggling behavior across breakpoints.
Overview
Refines Settings UI layout for responsiveness:
SettingsModalbecomes more viewport-aware (taller max height, scrollable nav, wider max width) andSettingsPageis restructured to a centered content rail with a stable, scrollable left nav.Makes settings open/close behavior consistent by introducing a single
handleToggleSettingsPageused by both keyboard shortcuts and the titlebar settings button.Adjusts global shortcut dispatch in
useKeyboardShortcutsso only the command palette is treated as blocking; settings no longer force-closes when using other global view shortcuts.Fixes left sidebar state persistence by separating
desktopOpen(persisted) frommobileOpen(ephemeral), preventing breakpoint transitions from permanently collapsing the desktop sidebar, and updatesThemeCardoption buttons to reflow cleanly under zoom/larger text.Written by Cursor Bugbot for commit 125c1be. This will update automatically on new commits. Configure here.