fix(terminal): correct CSI handler params for DECRQM workaround#993
Merged
arnestrickmann merged 1 commit intomainfrom Feb 20, 2026
Merged
fix(terminal): correct CSI handler params for DECRQM workaround#993arnestrickmann merged 1 commit intomainfrom
arnestrickmann merged 1 commit intomainfrom
Conversation
…rkaround
The registerCsiHandler callback receives params as (number | number[])[]
directly, not as an object with a .params property. This caused a crash
("Cannot read properties of undefined (reading '0')") when agents like
OpenCode sent DECRQM escape sequences.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryFixed critical crash in terminal spawning by correcting the CSI handler callback parameter type for the DECRQM workaround. Key changes:
Impact:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| src/renderer/terminal/TerminalSessionManager.ts | Fixed critical type error in CSI handler callback - corrected params type from object to array, preventing crash when OpenCode sends DECRQM sequences |
Last reviewed commit: 91ab080
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cannot read properties of undefined (reading '0')atTerminalSessionManager.ts:215registerCsiHandlercallback receivesparamsas(number | number[])[]directly, not as an object with a.paramsproperty — the code was accessingparams.params[0]which isundefinedTest plan
🤖 Generated with Claude Code