Added local translations as param to locadex start#396
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added local translations support to Locadex CLI, enabling developers to use file-based translations with GT config integration and loadTranslations.ts.
- Added
--local-translationsflag to Locadex CLI start command inpackages/locadex/src/cli.ts - Implemented
CliOptionstype withlocalTranslationsboolean inpackages/locadex/src/types/cli.ts - Extended
LocadexManagerwith CLI options storage inpackages/locadex/src/utils/locadexManager.ts - Added automatic cleanup for
loadTranslations.tsinpackages/locadex/src/tasks/i18n.ts - Implemented GT config generation and loadTranslations.ts creation in
packages/locadex/src/tasks/setup.ts
5 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
archie-mckenzie
left a comment
archie-mckenzie
left a comment
There was a problem hiding this comment.
Is adding local translations entirely programmatic or is Locadex involved at all? It seems entirely programmatic from looking at the code -- please confirm.
There was a problem hiding this comment.
Is there a consistent naming scheme we can have with the CLI tool? Does the CLI tool call these "local translations"?
There was a problem hiding this comment.
- Its all programmatic
- the cli tool has "--translations-dir " would this be better?
| const filePath = path.join(appDirectory, 'src', 'loadTranslations.js'); | ||
| writeFileSync(filePath, loadTranslationsContent); |
There was a problem hiding this comment.
You'll have to first check if they have a src folder. If they don't, it should just write to the appDir
3 participants
No description provided.