Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Added a new format command option (-f, --formatCmd) across Locadex CLI commands to support custom file formatting tools instead of auto-detected formatters.
- Added
formatCmdoption topackages/locadex/src/types/cli.tsCLI interface for specifying custom formatting commands - Implemented formatting execution logic in
packages/locadex/src/tasks/setup.tsusing execFunction - Enhanced
packages/locadex/src/tasks/i18n.tswith conditional logic to use custom format command or fallback to auto-detection - Potential security consideration: format command string validation is currently missing
4 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| import { retrieveCredentials } from 'gtx-cli/utils/credentials'; | ||
| import { isGTAuthConfigured } from '../utils/config.js'; | ||
| import { CliOptions } from '../types/cli.js'; | ||
| import { execFunction } from 'src/utils/exec.js'; |
Contributor
There was a problem hiding this comment.
logic: Relative import path 'src/utils/exec.js' may cause issues. Should use '../utils/exec.js' instead
Suggested change
| import { execFunction } from 'src/utils/exec.js'; | |
| import { execFunction } from '../utils/exec.js'; |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.