Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Major refactoring of the Locadex package to migrate from CLI-based Claude integration to the official @anthropic-ai/claude-code TypeScript SDK.
- Removed
packages/locadex/src/types/claude-sdk.tsand migrated to official SDK types - Refactored
packages/locadex/src/utils/claudeCode.tsto use SDK instead of child_process.spawn - Simplified MCP server configuration in
packages/locadex/src/utils/locadexManager.tswith new SDK integration - Unified translation status logging with spinner approach in
packages/locadex/src/tasks/i18n.ts - Streamlined error handling to use stdout instead of stderr for translation errors
7 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Comment on lines
+318
to
+320
| } finally { | ||
| // pass | ||
| } |
Contributor
There was a problem hiding this comment.
style: Empty finally block with just a comment. Either remove the try/finally or add necessary cleanup code.
Suggested change
| } finally { | |
| // pass | |
| } | |
| try { | |
| for await (const message of query({ | |
| prompt, | |
| abortController: combinedController, | |
| options: queryOptions, | |
| })) { | |
| const result = this.handleSDKOutput(message, _obs); | |
| if (!result.success) { | |
| throw new AgentProcessError( | |
| `[${this.id}] Claude Code error: ${result.error}`, | |
| undefined | |
| ); | |
| } | |
| } | |
| } |
Comment on lines
+154
to
+156
| // if (!this.debug) { | ||
| // return; | ||
| // } |
Contributor
There was a problem hiding this comment.
logic: commented-out debug check prevents initialization of required state files. Either remove the commented code or implement the debug-only logic properly
Suggested change
| // if (!this.debug) { | |
| // return; | |
| // } | |
| // ==== DEBUG Settings ==== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.