Skip to content

fix: move test_huggingface.py to granite4.1; and small rag intrinsic …#1008

Merged
jakelorocco merged 3 commits intomainfrom
jal/hf-test-4.1
May 4, 2026
Merged

fix: move test_huggingface.py to granite4.1; and small rag intrinsic …#1008
jakelorocco merged 3 commits intomainfrom
jal/hf-test-4.1

Conversation

@jakelorocco
Copy link
Copy Markdown
Contributor

@jakelorocco jakelorocco commented May 4, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue: Fixes

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

…function signature fix

Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@github-actions github-actions Bot added the bug Something isn't working label May 4, 2026
@jakelorocco jakelorocco requested review from frreiss and nrfulton May 4, 2026 20:41
@jakelorocco jakelorocco marked this pull request as ready for review May 4, 2026 20:41
@jakelorocco jakelorocco requested a review from a team as a code owner May 4, 2026 20:41
@jakelorocco jakelorocco requested a review from akihikokuroda May 4, 2026 20:41
@jakelorocco
Copy link
Copy Markdown
Contributor Author

I will open up follow up issues to fix this longterm. We will need some way to default to requirement-checking aloras if we want to maintain this behavior.

@jakelorocco jakelorocco removed the request for review from akihikokuroda May 4, 2026 20:59
Copy link
Copy Markdown
Collaborator

@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/examples/intrinsics/intrinsics.py Outdated
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
@jakelorocco jakelorocco enabled auto-merge May 4, 2026 21:33
@jakelorocco jakelorocco added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 0617bd9 May 4, 2026
8 checks passed
@jakelorocco jakelorocco deleted the jal/hf-test-4.1 branch May 4, 2026 22:21
planetf1 added a commit to planetf1/mellea that referenced this pull request May 5, 2026
…1-3b

Upstream generative-computing#981 and generative-computing#1008 standardised intrinsic examples on
ibm-granite/granite-4.1-3b (context_relevance stays on 4.0 as 4.1 is
not supported there). Aligns the Guardian migration docs with the
rest of the intrinsic examples now that the blocking PRs have merged.

No logic changes; identical output semantics for guardian_check(),
policy_guardrails(), factuality_detection(), factuality_correction().

Assisted-by: Claude Code
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants