refactor: get instructions from upstream guardian adapters#1037
Merged
psschwei merged 11 commits intoMay 18, 2026
Conversation
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Member
Author
|
cc @pronics2004 |
Member
Author
|
Also note: there's updated |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Member
Author
|
Latest commit uses pre-existing config file override |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
b76390a to
b8d180d
Compare
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
This reverts commit d61879a.
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
jakelorocco
requested changes
May 18, 2026
Contributor
jakelorocco
left a comment
There was a problem hiding this comment.
Thank you for the work; one small change. I feel strongly about making the defaults "just" work to cut down on complexity.
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Merged
via the queue into
generative-computing:main
with commit May 18, 2026
51569ea
10 checks passed
planetf1
added a commit
to planetf1/mellea
that referenced
this pull request
May 19, 2026
…omputing#1037 PR generative-computing#1037 expanded `guardian_check()` with a new `scoring_schema` parameter and deprecated `target_role` (still works, emits DeprecationWarning). Update docs to teach the new API: - safety-guardrails.md: replace `target_role="user"` with `scoring_schema="user_prompt"` in the input-gate and PII examples; document SCORING_SCHEMA_BANK keys; add a deprecation note - use-context-and-sessions.md: same sweep in the SafeChatSession example - glossary.md: add SCORING_SCHEMA_BANK entry mirroring CRITERIA_BANK No API surface changes in this PR — guardian.py taken from upstream/main during rebase (the PR's earlier `-> str` annotation fix is now redundant because generative-computing#1037 landed it independently). Assisted-by: Claude Code
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
The goal is to move the instruction logic out of the guardian helper function and into the upstream
io.yamlfiles for each adapter/intrinsic.I've included a
mellea/backends/adapters/_overlays/directory with the updatedio.yamlfiles as a temp fix until the actual files are available on Hugging Face. There's an envvar for disabling the overlays.Testing
Attribution