Skip to content

chore: remove code coverage from pytest screen output (#565)#568

Merged
psschwei merged 1 commit intogenerative-computing:mainfrom
planetf1:issue-565-coverage-output
Mar 4, 2026
Merged

chore: remove code coverage from pytest screen output (#565)#568
psschwei merged 1 commit intogenerative-computing:mainfrom
planetf1:issue-565-coverage-output

Conversation

@planetf1
Copy link
Contributor

@planetf1 planetf1 commented Mar 3, 2026

Misc PR

Fixes #565

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Removed --cov-report=term from the [tool.pytest.ini_options] configuration in pyproject.toml to prevent test runs from dumping large code coverage tables to the terminal. Test coverage is still generated and output to files htmlcov/ and coverage.json.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Mar 3, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

…puting#565)

<!-- mellea-pr-edited-marker: do not remove this marker -->
# Misc PR

## Type of PR

- [ ] Bug Fix
- [ ] New Feature
- [ ] Documentation
- [x] Other

## Description
- [x] Link to Issue: Fixes generative-computing#565

<!-- Brief description of the change being made along with an explanation. -->
Removed `--cov-report=term` from the `[tool.pytest.ini_options]` configuration in `pyproject.toml` to prevent test runs from dumping large code coverage tables to the terminal. Test coverage is still generated and output to files `htmlcov/` and `coverage.json`.

### Testing
- [ ] Tests added to the respective file if code was changed
- [ ] New code has 100% coverage if code as added
- [ ] Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)
@planetf1 planetf1 force-pushed the issue-565-coverage-output branch from cd85238 to 91b7138 Compare March 3, 2026 12:09
@planetf1
Copy link
Contributor Author

planetf1 commented Mar 3, 2026

@psschwei As per #565 I agree the output was getting burdensome.

I propose to remove the terminal output, but keep the other files so that other tools can be used to view that output either programatically (ie from the json) or by user in browser (html).

I did wonder whether to retain the output in CI -- but I think it causes lack of clarity there too. Instead we should have a review of coverage, get it to a sensible level we're happy with (if not already) then look at defining thresholds & add checks in CI?

@planetf1 planetf1 marked this pull request as ready for review March 3, 2026 12:12
@planetf1 planetf1 requested a review from a team as a code owner March 3, 2026 12:12
@planetf1 planetf1 requested review from jakelorocco and psschwei March 3, 2026 12:14
@psschwei
Copy link
Member

psschwei commented Mar 3, 2026

I did wonder whether to retain the output in CI -- but I think it causes lack of clarity there too.

I agree.

If it is possible to fold the code coverage screen output into a different step (so that it can be collapsed / ignored in the UI), then I could see leaving it in. But the higher-value thing is probably to define and verify thresholds as you say above.

@psschwei psschwei added this pull request to the merge queue Mar 4, 2026
Merged via the queue into generative-computing:main with commit a1e0917 Mar 4, 2026
5 checks passed
planetf1 added a commit to planetf1/mellea that referenced this pull request Mar 6, 2026
…puting#565) (generative-computing#568)

<!-- mellea-pr-edited-marker: do not remove this marker -->
# Misc PR

## Type of PR

- [ ] Bug Fix
- [ ] New Feature
- [ ] Documentation
- [x] Other

## Description
- [x] Link to Issue: Fixes generative-computing#565

<!-- Brief description of the change being made along with an explanation. -->
Removed `--cov-report=term` from the `[tool.pytest.ini_options]` configuration in `pyproject.toml` to prevent test runs from dumping large code coverage tables to the terminal. Test coverage is still generated and output to files `htmlcov/` and `coverage.json`.

### Testing
- [ ] Tests added to the respective file if code was changed
- [ ] New code has 100% coverage if code as added
- [ ] Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Code Coverage out of screen output

3 participants