Skip to content

docs: fix MelleaPlugin/MelleaBasePayload missing from API coverage (#…#670

Merged
planetf1 merged 2 commits intogenerative-computing:mainfrom
planetf1:docs/plugin-api-coverage-667
Mar 17, 2026
Merged

docs: fix MelleaPlugin/MelleaBasePayload missing from API coverage (#…#670
planetf1 merged 2 commits intogenerative-computing:mainfrom
planetf1:docs/plugin-api-coverage-667

Conversation

@planetf1
Copy link
Contributor

@planetf1 planetf1 commented Mar 17, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue:

Fixes #667

Replace dual if/else class definitions in mellea/plugins/base.py with dynamic base classes (Option 2 from #667) so Griffe's static AST parser sees a single ClassDef node per class and always picks up the authoritative docstring. Stub __init__ is applied post-hoc when cpex is not installed to preserve the existing ImportError behaviour.

Also converts check_certainty and requirement_check in mellea/stdlib/components/intrinsic/core.py from Sphinx :param:/:return: style to Google Args:/Returns: sections so Griffe's quality audit recognises them. These were introduced in #551.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@planetf1 planetf1 requested a review from jakelorocco March 17, 2026 17:49
@planetf1
Copy link
Contributor Author

Tested with/without package, for docstrings & in vscode, and tests.

…enerative-computing#667)

Replace dual if/else class definitions with dynamic base classes so
Griffe's static AST parser sees a single ClassDef node per class and
always picks up the authoritative docstring.
@planetf1 planetf1 force-pushed the docs/plugin-api-coverage-667 branch from c8567ea to 506e3f9 Compare March 17, 2026 17:53
The Sphinx :param:/:return: style is not recognised by Griffe's
quality audit. Convert to Google Args/Returns sections.
@planetf1 planetf1 marked this pull request as ready for review March 17, 2026 18:00
@planetf1 planetf1 requested a review from a team as a code owner March 17, 2026 18:00
@planetf1 planetf1 added the documentation Improvements or additions to documentation label Mar 17, 2026
@planetf1 planetf1 enabled auto-merge March 17, 2026 18:13
@planetf1 planetf1 added this pull request to the merge queue Mar 17, 2026
Merged via the queue into generative-computing:main with commit 17d48d7 Mar 17, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: MelleaPlugin and MelleaBasePayload missing from API coverage

2 participants