Appending logs to ctx for genslots #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinash2692
changed the title
nrfulton
approved these changes
Aug 19, 2025
| assert len(generate_logs) == 1, "Simple call can only add one generate_log" | ||
| generate_logs[0].is_final_result = True | ||
|
|
||
| self.ctx.insert_turn( |
Contributor
There was a problem hiding this comment.
I have to admit that I don't quite know if I understand how @HendrikStrobelt intends turns to be used. I am going to approve and merge this PR because we need some visibility for genslots.
@HendrikStrobelt : I'll leave it to you to review this use of insert_turn post-facto when he returns and open an issue (assigned to me and @avinash2692 ) if there are any issues. If there are issues, then we need to both fix them and also document the meaning of last_turn vs. last_prompt vs. last_output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #51 by adding logs and a turn to
MelleaSession.ctxso that we can usesession.last_prompt()forgenerativeslots.