fix: exclude tooling from mypy check#748
Merged
planetf1 merged 1 commit intogenerative-computing:mainfrom Mar 26, 2026
Merged
Conversation
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
approved these changes
Mar 26, 2026
Merged
via the queue into
generative-computing:main
with commit Mar 26, 2026
b9a8684
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Updates mypy configuration to exclude doc tooling
Fixes #747
Our pre-commit runs mypy which validates types and therefore needs to have all dependencies available for the code it is checking. Since griffe (used by docs pipeline) is only in the 'dev' group, and we only use 'uv run' for mypy, it will not have access to those dependencies.
An alternative option is ensuring mypy check installs/syncs all optional dependencies including dev. However this is a bigger decision - it has more impact, so I am not proposing that here (aside: this mypy issue may occur in other areas .. we may need to consider this in future)
Additionally I've moved the exclusion into pyproject.toml which allows the invocation in pre-commit to not have to specify additional excludes & keeps the config consistent
Testing