Skip to content

chore: enforce commit formatting on PR titles#750

Merged
psschwei merged 1 commit intogenerative-computing:mainfrom
psschwei:actions-pr-title
Mar 26, 2026
Merged

chore: enforce commit formatting on PR titles#750
psschwei merged 1 commit intogenerative-computing:mainfrom
psschwei:actions-pr-title

Conversation

@psschwei
Copy link
Copy Markdown
Member

@psschwei psschwei commented Mar 26, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Enforces mergify rule on PR titles via existing github action that adds labels.
Once this merges, we can disable the mergify action

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@psschwei psschwei requested a review from a team as a code owner March 26, 2026 21:16
@github-actions github-actions bot added the bug Something isn't working label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@psschwei psschwei changed the title fix: enforce commit formatting on PR titles chore: enforce commit formatting on PR titles Mar 26, 2026
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@psschwei psschwei removed the bug Something isn't working label Mar 26, 2026
@psschwei psschwei enabled auto-merge March 26, 2026 21:19
@psschwei
Copy link
Copy Markdown
Member Author

We can also add a similar action to mellea-contribs and deprecate mergify for our whole org

@planetf1
Copy link
Copy Markdown
Contributor

Have you considered github's native checks for metadata on push? That can match a regex without any custom action - built in.

It can enforce on commit, title etc.

@psschwei
Copy link
Copy Markdown
Member Author

Have you considered github's native checks for metadata on push? That can match a regex without any custom action - built in.

It can enforce on commit, title etc.

As mentioned in the issue, those are only available on an enterprise plan (which we don't have)

Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues adding this

@psschwei psschwei added this pull request to the merge queue Mar 26, 2026
Merged via the queue into generative-computing:main with commit 54feda6 Mar 26, 2026
14 checks passed
@psschwei psschwei deleted the actions-pr-title branch March 26, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conventional commits - consider mergify -> native github

3 participants