Merged
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
jakelorocco
approved these changes
Mar 30, 2026
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further optimizations to the GPU VRAM when running tests.
Type of PR
Description
###F ix GPU OOM in test runs: ollama lifecycle ownership + VRAM timing**
run_tests_with_ollama.shstarts and warms up all three ollama models unconditionally, even when an external process has already started the server — fragmenting VRAM before HF tests run and triggering OOMOLLAMA_EXTERNALandOLLAMA_SKIP_WARMUPenv guards to the shell script so an external orchestrator can own the lifecycle (both default to0so standalone use is unaffected)conftest.pyhandles VRAM timing — loading models right before the ollama test group and evicting after viakeep_alive_check_ollama_available()hardcoded port to respectOLLAMA_HOST/OLLAMA_PORTenv varstest_alora_train_integration.pyfor all tests.Testing