Skip to content

docs: remove pre-IVR validation and update readme with v2 benchmark results#769

Merged
ajbozarth merged 1 commit intogenerative-computing:mainfrom
ajbozarth:remove-pre-ivr-validation
Apr 1, 2026
Merged

docs: remove pre-IVR validation and update readme with v2 benchmark results#769
ajbozarth merged 1 commit intogenerative-computing:mainfrom
ajbozarth:remove-pre-ivr-validation

Conversation

@ajbozarth
Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth commented Mar 31, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue: Fixes

Updates the qiskit_code_validation example and its README based on a re-benchmarking run after removing the pre-IVR input validation from the example. Previously, the example ran a pre-condition validation on the input code before entering the IVR loop, which made the repair loop mostly unnecessary. This PR removes that pre-validation so the IVR loop handles all validation end-to-end, and updates the README to reflect the corrected pipeline description and new benchmark numbers.

Changes:

  • Remove pre-IVR input validation from generate_validated_qiskit_code() — IVR now handles all validation
  • Update README: IVR pipeline steps, strategy performance table (new numbers from v2 benchmark), expected output, and "What This Example Does" description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code was added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

…esults

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth self-assigned this Mar 31, 2026
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@ajbozarth ajbozarth marked this pull request as ready for review March 31, 2026 22:43
@ajbozarth ajbozarth requested a review from a team as a code owner March 31, 2026 22:43
@ajbozarth
Copy link
Copy Markdown
Contributor Author

cc @vabarbosa

new benchmark analysis can be seen at https://github.com/ajbozarth/toolbox/blob/main/mellea/qiskit_code_validation/benchmarking/run_ivr_20260331_183642/analysis_v2.md

@ajbozarth ajbozarth requested a review from psschwei March 31, 2026 22:45
Copy link
Copy Markdown
Contributor

@vabarbosa vabarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajbozarth ajbozarth added this pull request to the merge queue Apr 1, 2026
Merged via the queue into generative-computing:main with commit 951145d Apr 1, 2026
9 checks passed
@ajbozarth ajbozarth deleted the remove-pre-ivr-validation branch April 1, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants