fix: handle stale .vllm-venv in test runner#829
Merged
planetf1 merged 2 commits intogenerative-computing:mainfrom Apr 13, 2026
Merged
fix: handle stale .vllm-venv in test runner#829planetf1 merged 2 commits intogenerative-computing:mainfrom
planetf1 merged 2 commits intogenerative-computing:mainfrom
Conversation
Add --clear to the uv venv call so a leftover venv from a killed job or incomplete cleanup is replaced instead of causing a hard failure. Fixes generative-computing#828
When CACHE_DIR is unset the test runner creates .vllm-venv in the repo root. Without a gitignore entry this multi-GB directory can be accidentally committed or rsynced. Use a wildcard to cover any future isolated venvs following the same naming pattern.
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
planetf1
changed the title
jakelorocco
approved these changes
Apr 13, 2026
Merged
via the queue into
generative-computing:main
with commit Apr 13, 2026
fdddf8c
6 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: handle stale .vllm-venv in test runner
Type of PR
Description
The test runner's
trap cleanup EXITremoves.vllm-venvon normal exit, but hard kills (SIGKILL, OOM, LSF timeout) bypass the trap, leaving a stale directory that causesuv venvto fail on the next run.Changes:
--clearto theuv venvcall so stale directories are replaced.*-venvto.gitignore— whenCACHE_DIRis unset the venv lands in the repo rootTesting
uv venv --clearreplaces an existing directory