feat: first pass at carrying contextvars though async flows#878
Merged
AngeloDanducci merged 4 commits intogenerative-computing:mainfrom Apr 17, 2026
Merged
feat: first pass at carrying contextvars though async flows#878AngeloDanducci merged 4 commits intogenerative-computing:mainfrom
AngeloDanducci merged 4 commits intogenerative-computing:mainfrom
Conversation
AngeloDanducci
requested review from
a team,
jakelorocco and
nrfulton
as code owners
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Contributor
Author
|
Rebased after the other logging merge. |
ajbozarth
reviewed
Apr 17, 2026
Contributor
ajbozarth
left a comment
ajbozarth
left a comment
There was a problem hiding this comment.
Review from Claude Code (via @ajbozarth). Minor note on the commits — "first pass at carrying contextvars though async flows" has a typo and is missing the feat: prefix. Just an FYI in case someone reads the squash commit message.
ajbozarth
approved these changes
Apr 17, 2026
Contributor
ajbozarth
left a comment
ajbozarth
left a comment
There was a problem hiding this comment.
In addition to the Claude review above I also ran the tests locally and looked through the code changes manually and overall it LGTM. The Claude items aren't blockers, in it's own words:
Neither is blocking — they're more "should fix before this pattern spreads" than "this is broken now."
jakelorocco
approved these changes
Apr 17, 2026
Merged
via the queue into
generative-computing:main
with commit Apr 17, 2026
8501b3d
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
session_id,request_id,model_id, andsampling_iterationthrough async flows #459Testing
Attribution