Skip to content

Conversation

@jakelorocco
Copy link
Contributor

m.act is the default implementation of how a session interacts with a backend. All other m.* functions (besides validate) will call that function and do pre/post processing to get the same results as before.

Notes:

  • m.validate can't use act since requirements directly call the backend.generate functions; we can "fix" this if we have requirements take MelleaSession objects
  • act handles context additions; this means that query and transform no longer handle adding to context differently depending on the context
  • tool calling for transform will get moved in a future PR (there are no regressions here)

All tests pass.

@jakelorocco jakelorocco changed the base branch from main to hen/sampling_strategy_new August 25, 2025 19:41
@jakelorocco jakelorocco changed the base branch from hen/sampling_strategy_new to main August 25, 2025 19:41
@jakelorocco
Copy link
Contributor Author

I've messed up the refs here by pulling in main while building off hen/sampling_strategy_new. Will need to wait for that PR.

@jakelorocco jakelorocco changed the base branch from main to jal/genslot-sampling-with-hen-changes August 29, 2025 18:11
@jakelorocco jakelorocco changed the base branch from jal/genslot-sampling-with-hen-changes to main August 29, 2025 18:11
@jakelorocco jakelorocco marked this pull request as ready for review August 29, 2025 20:00
@jakelorocco
Copy link
Contributor Author

I've fixed the refs; final changes:

  • added generic capabilities to m.act
  • m.* functions use m.act under the hood
  • removed m.genslot since that's identical to m.act
  • fixed a few small things in the sampling file
  • added overloads to m.act and m.instruct so that return types aren't unions

All tests pass (ran locally).

Copy link
Contributor

@HendrikStrobelt HendrikStrobelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelorocco jakelorocco merged commit 00fd928 into main Sep 3, 2025
4 checks passed
@jakelorocco jakelorocco deleted the jal/m-act-refactor branch September 3, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants