Skip to content

fix: pin uncertainty and context-attribution revisions and update uncertai…#970

Merged
AngeloDanducci merged 1 commit intogenerative-computing:mainfrom
AngeloDanducci:ad-969
Apr 30, 2026
Merged

fix: pin uncertainty and context-attribution revisions and update uncertai…#970
AngeloDanducci merged 1 commit intogenerative-computing:mainfrom
AngeloDanducci:ad-969

Conversation

@AngeloDanducci
Copy link
Copy Markdown
Contributor

@AngeloDanducci AngeloDanducci commented Apr 29, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

@AngeloDanducci AngeloDanducci requested a review from a team as a code owner April 29, 2026 22:04
@github-actions github-actions Bot added the bug Something isn't working label Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@avinash2692 avinash2692 mentioned this pull request Apr 29, 2026
8 tasks
@jakelorocco
Copy link
Copy Markdown
Contributor

@frreiss, should we pin revisions for the intrinsics tests? That way updates to the adapters don't immediately impact our testing infrastructure? Or do we think that there's a risk that the adapters get updated but Mellea doesn't?

Copy link
Copy Markdown
Contributor

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the temperature add is needed to fix CI.

Re: pinning the version, we can do what Fred recommends but at least we already know our CI is breakable with a small config change.

@jakelorocco
Copy link
Copy Markdown
Contributor

I was thinking more about the version pinning. My suggestion: I think we can xfail these tests when the revision changes. We can also add a new test that runs only during nightlies / outside of CICD that fails if any of the revisions changes. That way our CICD pipeline is less brittle but we are still aware of when changes happen.

@AngeloDanducci
Copy link
Copy Markdown
Contributor Author

I like both of those ideas better - I'll swap over to the xfail shortly.

@AngeloDanducci AngeloDanducci added this pull request to the merge queue Apr 30, 2026
Merged via the queue into generative-computing:main with commit c8cb77d Apr 30, 2026
12 checks passed
@AngeloDanducci AngeloDanducci deleted the ad-969 branch April 30, 2026 15:27
@frreiss
Copy link
Copy Markdown
Collaborator

frreiss commented Apr 30, 2026

@frreiss, should we pin revisions for the intrinsics tests? That way updates to the adapters don't immediately impact our testing infrastructure? Or do we think that there's a risk that the adapters get updated but Mellea doesn't?

If we pin every intrinsic to a different long string of base64 commit hash, we will quickly forget what we were doing. Maintenance will require getting every model’s owner on the line on a regular basis to determine what is the right commit hash to pin each intrinsic to this week. People will not want to go through that hassle and the files on the head of the main branch will become incompatible with Mellea. People who use the intrinsics through high level APIs will get outdated models in their applications and won’t understand why.

Maybe tag the release and pin the tag instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: test_canned_input[uncertainty] fails due to unpinned/outdated HF repo revision

4 participants