Skip to content

fix: issues introduced by intrinsic changes#986

Merged
jakelorocco merged 4 commits intomainfrom
jal/fix-intrinsic-issues
May 1, 2026
Merged

fix: issues introduced by intrinsic changes#986
jakelorocco merged 4 commits intomainfrom
jal/fix-intrinsic-issues

Conversation

@jakelorocco
Copy link
Copy Markdown
Contributor

@jakelorocco jakelorocco commented May 1, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

@github-actions github-actions Bot added the bug Something isn't working label May 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@jakelorocco jakelorocco linked an issue May 1, 2026 that may be closed by this pull request
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
Assisted-by: CLAUDE:OPUS
@jakelorocco jakelorocco requested a review from nrfulton May 1, 2026 02:10
Comment thread test/backends/test_huggingface.py
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
@jakelorocco jakelorocco force-pushed the jal/fix-intrinsic-issues branch from 683173b to f456804 Compare May 1, 2026 12:22
@jakelorocco jakelorocco marked this pull request as ready for review May 1, 2026 13:04
@jakelorocco jakelorocco requested review from a team as code owners May 1, 2026 13:04
@jakelorocco jakelorocco requested a review from ajbozarth May 1, 2026 13:04
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but Claude had a couple nits:

pyproject.toml — xgrammar pin
The hard == pin works for urgency but creates maintenance debt. Two asks:

  • Expand the comment to reference the upstream issue/symptoms so future maintainers know when it's safe to unpin
  • Is there a follow-up issue open to revisit once upstream fixes it?

Test split
One gap: nothing directly exercises the tools=None formatter path from util.py. The fix looks obviously right, but a small unit test there would prevent a regression.

Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
@jakelorocco jakelorocco merged commit c57aba1 into main May 1, 2026
8 checks passed
@jakelorocco jakelorocco deleted the jal/fix-intrinsic-issues branch May 1, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing nightlies in 2026-04-30-0f95f84

3 participants