fix: issues introduced by intrinsic changes#986
Merged
jakelorocco merged 4 commits intomainfrom May 1, 2026
Merged
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
planetf1
reviewed
May 1, 2026
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
683173b to
f456804
Compare
9 tasks
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
ajbozarth
approved these changes
May 1, 2026
Contributor
ajbozarth
left a comment
There was a problem hiding this comment.
This LGTM, but Claude had a couple nits:
pyproject.toml — xgrammar pin
The hard == pin works for urgency but creates maintenance debt. Two asks:
- Expand the comment to reference the upstream issue/symptoms so future maintainers know when it's safe to unpin
- Is there a follow-up issue open to revisit once upstream fixes it?
Test split
One gap: nothing directly exercises the tools=None formatter path from util.py. The fix looks obviously right, but a small unit test there would prevent a regression.
4 tasks
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
2026-04-30-0f95f84#985Testing
Attribution