Skip to content

Fix #131 Workspaces directories in server are not being found#135

Merged
genericptr merged 7 commits intotrunkfrom
131-workspaces-directories-in-server-are-not-being-found
Jan 16, 2026
Merged

Fix #131 Workspaces directories in server are not being found#135
genericptr merged 7 commits intotrunkfrom
131-workspaces-directories-in-server-are-not-being-found

Conversation

@genericptr
Copy link
Copy Markdown
Owner

@genericptr genericptr commented Jan 10, 2026

@mvancanneyt It was broken since your refactor but I fixed the usage of the includeWorkspaceFoldersAsUnitPaths which was supposed to add unit paths to FPCOptions. This for projects without lazarus so that you can open a workspace and it can find files for you with adding them manually.

My question is, how does this interact with the lazconfig system? I'm looking in PasLS.LazConfig.pas and I don't see how it sets unit paths. Now that this is working I think it's going to conflict with the lazconfig.

@genericptr genericptr linked an issue Jan 10, 2026 that may be closed by this pull request
@mvancanneyt
Copy link
Copy Markdown
Collaborator

It won't conflict. The two systems are completely parallel. it just means many paths will be supplied twice.

Looking at the diff, it seems to me you simply didn't set the
``ServerSettings.includeWorkspaceFoldersAsUnitPathsorServerSettings.includeWorkspaceFoldersAsIncludePaths`
to true.

But I'd need to investigate more deeply. The diffs are not very clear, mixing formatting and functional changes...

In each case, The lazconfig system needs an update. Today you can simply use '/path/to/workspace/**' and the lazarus codetools will automatically add all subdirectories. So no special code required.

@genericptr
Copy link
Copy Markdown
Owner Author

Sorry for the messy diff, I'm trying to fix formatting as I go along. It was totally broken because it wasn't actually setting the compiler flags but that fixes this now. I'm going to merge this but if you need to update the laz config or this causes problems then please post a PR. Thanks Michael.

@genericptr genericptr merged commit 9d42814 into trunk Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspaces directories in server are not being found

2 participants