Skip to content

Restore patch-rebuild.yml workflow gutted during PR-build development#35

Merged
JonahBraun merged 1 commit into
masterfrom
fix/restore-patch-rebuild
Apr 23, 2026
Merged

Restore patch-rebuild.yml workflow gutted during PR-build development#35
JonahBraun merged 1 commit into
masterfrom
fix/restore-patch-rebuild

Conversation

@JonahBraun
Copy link
Copy Markdown

Restores .github/workflows/patch-rebuild.yml to its pre-1cf855f form. The workflow was replaced with a dev-time stub targeting pr-build.yml@feat/sideloader with a hardcoded PR number — it can't produce a stable release in that state.

Changes

  • .github/workflows/patch-rebuild.yml — restored byte-identically from 1cf855f~1. Two jobs: prepare (compute time-based RELEASE_VERSION, commit PATCH_REBUILD_INFO.md) and trigger-all-builds (repository_dispatch: [${quality}] with patch_rebuild: true and custom_release_version).

No other files touched — the downstream PATCH_REBUILD / CUSTOM_RELEASE_VERSION plumbing in stable-{linux,macos,windows}.yml is still in place and was not affected by the 48h of CI changes.

Test plan

  • git diff 1cf855f~1 -- .github/workflows/patch-rebuild.yml is empty (confirmed locally).
  • After merge, the Actions tab shows "Patch Rebuild (Force Build)" with the quality (stable/insider) + reason inputs restored.
  • Optional: dispatch once with quality=stable, reason="verify restore" to confirm the marker commit lands on master and the three stable-* workflows are triggered via repository_dispatch. Only do this if a real forced rebuild is desired; it will produce a live release.

The workflow was replaced with an 11-line dev stub in 1cf855f that
invoked pr-build.yml@feat/sideloader with a hardcoded pr_number: '31' —
a leftover from PR-build-flow development that didn't belong on master.

Restore the original two-job workflow: `prepare` reads upstream/
{quality}.json, computes a time-based RELEASE_VERSION, and commits
PATCH_REBUILD_INFO.md for traceability; `trigger-all-builds` fires
repository_dispatch: [{quality}] with patch_rebuild + custom version
so check_tags.sh forces SHOULD_BUILD=yes, SHOULD_DEPLOY=yes regardless
of the normal upstream-version gate.

This is the forcing function for releases when nothing in upstream/
stable.json changed — e.g. shipping a Codex patch fix, a bundled-
extension bump, or branding tweaks.

Content restored from 1cf855f~1 verbatim; downstream plumbing
(PATCH_REBUILD, CUSTOM_RELEASE_VERSION, GITHUB_EVENT_CLIENT_PAYLOAD)
in stable-{linux,macos,windows}.yml is already in place.
Copy link
Copy Markdown

@BenjaminScholtens BenjaminScholtens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JonahBraun JonahBraun merged commit bd487a9 into master Apr 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants