[ODM-10883] Rework api documentation, switch to opeanapi-generator-gradle-plugin#62
Merged
genestack-okunitsyn merged 48 commits intodevelopfrom Jan 11, 2024
Merged
Conversation
genestack-okunitsyn
force-pushed
the
feature/ODM-10883-api-documentation
branch
4 times, most recently
from
ada1e93 to
ca82a5a
Compare
genestack-okunitsyn
force-pushed
the
feature/ODM-10883-api-documentation
branch
from
ca82a5a to
21a2ee6
Compare
genestack-okunitsyn
changed the title
genestack-okunitsyn
force-pushed
the
feature/ODM-10883-api-documentation
branch
from
5a52959 to
0420794
Compare
genestack-okunitsyn
force-pushed
the
feature/ODM-10883-api-documentation
branch
from
1be4d8d to
e6aa021
Compare
genestack-okunitsyn
force-pushed
the
feature/ODM-10883-api-documentation
branch
from
f4423b1 to
540bed9
Compare
genestack-okunitsyn
force-pushed
the
feature/ODM-10883-api-documentation
branch
from
de4c77a to
a9a6905
Compare
m-smazhevsky
previously approved these changes
Jan 8, 2024
Contributor
m-smazhevsky
left a comment
m-smazhevsky
left a comment
There was a problem hiding this comment.
Looks good, I guess we need somebody from qa team to check the formatting in swagger
| operationId: "getAllVariants" | ||
| produces: | ||
| - "application/json" | ||
| description: |+ |
Contributor
There was a problem hiding this comment.
what happened with summary?
Contributor
Author
There was a problem hiding this comment.
I suppose it was removed in openapi specification V3. Couldn't find it in there.
Contributor
There was a problem hiding this comment.
shouldn't we replace it with title or smth?
Contributor
Author
There was a problem hiding this comment.
We could try, I'll create one more subtask for this, to find would be it helpful or not, thank you.
viapivov
approved these changes
Jan 11, 2024
m-smazhevsky
approved these changes
Jan 11, 2024
genestack-tg-gh-deploy
added a commit
that referenced
this pull request
Sep 16, 2024
…adle-plugin (#62) * [ODM-10883] Fully reworked solution to openapi-generator * [ODM-10883] Remove deprecated base path * [ODM-10883] Fix expression atomic endpoint * [ODM-10883] Try to fix test with openapi update * [ODM-10883] Fix predefined headers in omics endpoints * [ODM-10883] Add to all linkage * [ODM-10883] Switch to openapi * [ODM-10883] Make parameter nullable * [ODM-10883] Application.json to search endpoint * [ODM-10883] Set nullable with other approach * [ODM-10883] Set nullable with other approach, doubled * [ODM-10883] Bump gradle plugin * [ODM-10883] Remove nullable * [ODM-10883] Add additional properties as a string * [ODM-10883] Add nullable * [ODM-10883] Make feature string or dict * [ODM-10883] JsonMetadata attributes should be oneOf object/string * [ODM-10883] Test with 3.1.0 spec and null * [ODM-10883] Make all specs 3.1.0 * [ODM-10883] Remove oneOf, make it same as default * [ODM-10883] Try to fix it in new way * [ODM-10883] Test remove properties from feature * [ODM-10883] Set anyOf clearly * [ODM-10883] Test add properties to object * [ODM-10883] Add min properties 1 * [ODM-10883] Comment null for value * [ODM-10883] Value directly as a number * [ODM-10883] Remove readOnly from object * [ODM-10883] Put values in other way * [ODM-10883] VariantItem to properties * [ODM-10883] Remove read-only * Test another way * Remove items: string * [ODM-10883] Fix variantItem * [ODM-10883] Remove readonly from Item entities * [ODM-10883] Description readOnly * [ODM-10883] Add genotype to variantItem * [ODM-10883] Remove items to make it parse properly in lib * [ODM-10883] Replace unused host to / * [ODM-10883] Remove server section * [ODM-10883] Remove swager annotation * [ODM-10883] All requestBody as application/json * [ODM-10883] Fix description for manageData * [ODM-10883] All content-types */* as application/json * [ODM-10883] Remove template from example * Fix examples in jobs endpoint * [ODM-10883] Fix examples * [ODM-10883] Fix examples
tropnikovvl
added a commit
that referenced
this pull request
Apr 15, 2025
…adle-plugin (#62) * [ODM-10883] Fully reworked solution to openapi-generator * [ODM-10883] Remove deprecated base path * [ODM-10883] Fix expression atomic endpoint * [ODM-10883] Try to fix test with openapi update * [ODM-10883] Fix predefined headers in omics endpoints * [ODM-10883] Add to all linkage * [ODM-10883] Switch to openapi * [ODM-10883] Make parameter nullable * [ODM-10883] Application.json to search endpoint * [ODM-10883] Set nullable with other approach * [ODM-10883] Set nullable with other approach, doubled * [ODM-10883] Bump gradle plugin * [ODM-10883] Remove nullable * [ODM-10883] Add additional properties as a string * [ODM-10883] Add nullable * [ODM-10883] Make feature string or dict * [ODM-10883] JsonMetadata attributes should be oneOf object/string * [ODM-10883] Test with 3.1.0 spec and null * [ODM-10883] Make all specs 3.1.0 * [ODM-10883] Remove oneOf, make it same as default * [ODM-10883] Try to fix it in new way * [ODM-10883] Test remove properties from feature * [ODM-10883] Set anyOf clearly * [ODM-10883] Test add properties to object * [ODM-10883] Add min properties 1 * [ODM-10883] Comment null for value * [ODM-10883] Value directly as a number * [ODM-10883] Remove readOnly from object * [ODM-10883] Put values in other way * [ODM-10883] VariantItem to properties * [ODM-10883] Remove read-only * Test another way * Remove items: string * [ODM-10883] Fix variantItem * [ODM-10883] Remove readonly from Item entities * [ODM-10883] Description readOnly * [ODM-10883] Add genotype to variantItem * [ODM-10883] Remove items to make it parse properly in lib * [ODM-10883] Replace unused host to / * [ODM-10883] Remove server section * [ODM-10883] Remove swager annotation * [ODM-10883] All requestBody as application/json * [ODM-10883] Fix description for manageData * [ODM-10883] All content-types */* as application/json * [ODM-10883] Remove template from example * Fix examples in jobs endpoint * [ODM-10883] Fix examples * [ODM-10883] Fix examples
tropnikovvl
added a commit
that referenced
this pull request
Apr 15, 2025
…adle-plugin (#62) * [ODM-10883] Fully reworked solution to openapi-generator * [ODM-10883] Remove deprecated base path * [ODM-10883] Fix expression atomic endpoint * [ODM-10883] Try to fix test with openapi update * [ODM-10883] Fix predefined headers in omics endpoints * [ODM-10883] Add to all linkage * [ODM-10883] Switch to openapi * [ODM-10883] Make parameter nullable * [ODM-10883] Application.json to search endpoint * [ODM-10883] Set nullable with other approach * [ODM-10883] Set nullable with other approach, doubled * [ODM-10883] Bump gradle plugin * [ODM-10883] Remove nullable * [ODM-10883] Add additional properties as a string * [ODM-10883] Add nullable * [ODM-10883] Make feature string or dict * [ODM-10883] JsonMetadata attributes should be oneOf object/string * [ODM-10883] Test with 3.1.0 spec and null * [ODM-10883] Make all specs 3.1.0 * [ODM-10883] Remove oneOf, make it same as default * [ODM-10883] Try to fix it in new way * [ODM-10883] Test remove properties from feature * [ODM-10883] Set anyOf clearly * [ODM-10883] Test add properties to object * [ODM-10883] Add min properties 1 * [ODM-10883] Comment null for value * [ODM-10883] Value directly as a number * [ODM-10883] Remove readOnly from object * [ODM-10883] Put values in other way * [ODM-10883] VariantItem to properties * [ODM-10883] Remove read-only * Test another way * Remove items: string * [ODM-10883] Fix variantItem * [ODM-10883] Remove readonly from Item entities * [ODM-10883] Description readOnly * [ODM-10883] Add genotype to variantItem * [ODM-10883] Remove items to make it parse properly in lib * [ODM-10883] Replace unused host to / * [ODM-10883] Remove server section * [ODM-10883] Remove swager annotation * [ODM-10883] All requestBody as application/json * [ODM-10883] Fix description for manageData * [ODM-10883] All content-types */* as application/json * [ODM-10883] Remove template from example * Fix examples in jobs endpoint * [ODM-10883] Fix examples * [ODM-10883] Fix examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.